Skip to content

Commit dbc09b8

Browse files
authored
Merge pull request #55 from topcoder-platform/issues-384
Issues-386: design tweaks
2 parents cd79723 + a2f77f8 commit dbc09b8

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

class.groups.plugin.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class GroupsPlugin extends Gdn_Plugin {
3434
const ROLE_TOPCODER_MANAGER = 'Connect Manager';
3535

3636
const UI = [
37-
'challenge' => ['BreadcrumbLevel1Title' => 'Challenges',
37+
'challenge' => ['BreadcrumbLevel1Title' => 'Challenge Discussions',
3838
'BreadcrumbLevel1Url' => self::ROUTE_CHALLENGE_GROUPS,
3939
'CreateGroupTitle' => 'Create Challenge',
4040
'EditGroupTitle' => 'Edit Challenge',
@@ -349,7 +349,7 @@ public function base_discussionOptionsDropdown_handler($sender, $args){
349349
}
350350
}
351351

352-
public function base_afterDiscussionFilters_handler($sender){
352+
public function base_beforeUserLinksDiscussionFilters_handler($sender){
353353
$this->addGroupLinkToMenu($sender);
354354
}
355355

@@ -819,8 +819,8 @@ private function getTopcoderProjectRoles($user, $resources = null, $roleResource
819819
private function addGroupLinkToMenu($sender) {
820820
if(Gdn::session()->isValid()) {
821821

822-
echo '<li class="'.$this->getMenuItemCssClassFromQuery($sender, 'challenge').'">'. anchor('Challenges', GroupsPlugin::ROUTE_CHALLENGE_GROUPS).'</li>';
823-
echo '<li class="'.$this->getMenuItemCssClassFromQuery($sender, 'regular').'">'. anchor('Groups', GroupsPlugin::ROUTE_REGULAR_GROUPS).'</li>';
822+
echo '<li class="'.$this->getMenuItemCssClassFromQuery($sender, 'challenge').'">'. anchor('Challenge Discussions', GroupsPlugin::ROUTE_CHALLENGE_GROUPS).'</li>';
823+
// echo '<li class="'.$this->getMenuItemCssClassFromQuery($sender, 'regular').'">'. anchor('Groups', GroupsPlugin::ROUTE_REGULAR_GROUPS).'</li>';
824824
// echo '<li class="'.$this->getMenuItemCssClassFromRequestMethod($sender, 'mine').'">'. anchor('My Challenges & Groups', GroupsPlugin::ROUTE_MY_GROUPS).'</li>';
825825
}
826826
}

controllers/class.groupcontroller.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function initialize() {
5151
// Add modules
5252
$this->addModule('NewDiscussionModule');
5353
$this->addModule('DiscussionFilterModule');
54-
$this->addModule('CategoriesModule');
54+
//$this->addModule('CategoriesModule');
5555
$this->addModule('BookmarkedModule');
5656
}
5757

@@ -573,7 +573,7 @@ public function discussions($GroupID='',$Page = false) {
573573

574574
$Group = $this->GroupModel->getByGroupID($GroupID);
575575
$this->setData('Group',$Group);
576-
$this->setData('Breadcrumbs', [['Name' => t('Challenges'), 'Url' => GroupsPlugin::GROUPS_ROUTE],
576+
$this->setData('Breadcrumbs', [['Name' => t('Challenge Discussions'), 'Url' => GroupsPlugin::GROUPS_ROUTE],
577577
['Name' => $Group->Name, 'Url' => GroupsPlugin::GROUP_ROUTE.$Group->GroupID], ['Name' => t('Discussions')]]);
578578

579579
// Check for the feed keyword.
@@ -683,7 +683,7 @@ public function announcement($GroupID=''){
683683
}
684684

685685
$this->setData('Breadcrumbs',
686-
[['Name' => t('Challenges'), 'Url' => GroupsPlugin::GROUPS_ROUTE],
686+
[['Name' => t('Challenge Discussions'), 'Url' => GroupsPlugin::GROUPS_ROUTE],
687687
['Name' => $Group->Name, 'Url' => GroupsPlugin::GROUP_ROUTE.$Group->GroupID], ['Name' => t('New Announcement')]]);
688688
$this->title('New Announcement');
689689
$this->setDiscussionData($Group, 2);
@@ -703,7 +703,7 @@ public function discussion($GroupID=''){
703703
throw permissionException();
704704
}
705705

706-
$this->setData('Breadcrumbs', [['Name' => t('Challenges'), 'Url' => GroupsPlugin::GROUPS_ROUTE],
706+
$this->setData('Breadcrumbs', [['Name' => t('Challenge Discussions'), 'Url' => GroupsPlugin::GROUPS_ROUTE],
707707
['Name' => $Group->Name, 'Url' => GroupsPlugin::GROUP_ROUTE.$Group->GroupID], ['Name' => t('New Discussion')]]);
708708
$this->title('New Discussion');
709709
$this->setDiscussionData($Group, 1);

controllers/class.groupscontroller.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ public function initialize() {
3939
// Add modules
4040
$this->addModule('NewDiscussionModule');
4141
$this->addModule('DiscussionFilterModule');
42-
$this->addModule('CategoriesModule');
42+
//$this->addModule('CategoriesModule');
4343
$this->addModule('BookmarkedModule');
4444
$this->fireEvent('AfterInitialize');
4545
}
4646

4747
public function setFilterPageData($filter) {
4848
if($filter == 'challenge') {
4949
$this->View = 'index';
50-
$this->title('Challenges');
50+
$this->title('Challenge Discussions');
5151
$this->setData('Title', 'My Challenges');
5252
$this->setData('ShowAddButton', false);
5353
$this->setData('AddButtonTitle', 'Challenge');
@@ -59,7 +59,7 @@ public function setFilterPageData($filter) {
5959
$this->setData('AllGroupButtonLink', '/groups/all/?filter=challenge');
6060
$this->setData('NoGroups', 'No challenges were found.');
6161
$this->setData('Breadcrumbs', [
62-
['Name' => 'Challenges', 'Url' => GroupsPlugin::ROUTE_CHALLENGE_GROUPS]]);
62+
['Name' => 'Challenge Discussions', 'Url' => GroupsPlugin::ROUTE_CHALLENGE_GROUPS]]);
6363
} else if($filter == 'regular' ) {
6464
$this->View = 'index';
6565
$this->title('Groups');

0 commit comments

Comments
 (0)