Enable Move if user has group moderation permssion only

Author: atelomycterus

class.groups.plugin.php

@@ -333,6 +333,9 @@ public function base_discussionOptionsDropdown_handler($sender, $args){
 
             if ($canMove === false) {
                 $options->removeItem('move');
+            } else {
+                // User doesn't have Vanilla Moderation permission but can moderate group discussions
+                $options->addLink(t('Move'), '/moderation/confirmdiscussionmoves?discussionid='.$Discussion->DiscussionID, 'move', 'MoveDiscussion Popup');
             }
 
             if ($canRefetch === false) {

models/class.groupmodel.php

@@ -1737,12 +1737,14 @@ public function canMoveDiscussion($discussion) {
         }
 
         $groupID = $this->findGroupIDFromDiscussion($discussion);
-        $group = $this->getByGroupID($groupID);
-        $result = $this->getGroupRoleFor(Gdn::session()->UserID, $groupID);
-        $groupRole = val('Role', $result, null);
-        if($groupRole === GroupModel::ROLE_LEADER || Gdn::session()->UserID === $group->OwnerID
-            || Gdn::session()->checkPermission(GroupsPlugin::GROUPS_MODERATION_MANAGE_PERMISSION)) {
-            return true;
+        if($groupID) {
+            $group = $this->getByGroupID($groupID);
+            $result = $this->getGroupRoleFor(Gdn::session()->UserID, $groupID);
+            $groupRole = val('Role', $result, null);
+            if ($groupRole === GroupModel::ROLE_LEADER || Gdn::session()->UserID === $group->OwnerID
+                || Gdn::session()->checkPermission(GroupsPlugin::GROUPS_MODERATION_MANAGE_PERMISSION)) {
+                return true;
+            }
         }
         return false;
     }