Skip to content

Commit 44709a1

Browse files
authored
Merge pull request #57 from topcoder-platform/issues-398
Issues-398: hide manage members, show archived attr
2 parents 5343d9b + 604f559 commit 44709a1

File tree

2 files changed

+29
-19
lines changed

2 files changed

+29
-19
lines changed

design/groups.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -680,6 +680,10 @@ li.ui-timepicker-selected .ui-timepicker-duration,
680680
float: left
681681
}
682682

683+
.DataList .PhotoWrap.ProfilePhotoMedium img{
684+
height: 40px;
685+
}
686+
683687
.Section-Group .DismissMessage {
684688
display: none
685689
}

views/group/helper_functions.php

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function getGroupOptionsDropdown($group = null) {
5757
$canDelete = $groupModel->canDelete($group) ;
5858
$canLeave = $groupModel->canLeave($group);
5959
$canInviteMember = $groupModel->canInviteNewMember($group);
60-
$canManageMembers = $groupModel->canManageMembers($group);
60+
// $canManageMembers = $groupModel->canManageMembers($group);
6161
$canManageCategories = $groupModel->canManageCategories($group);
6262
$canFollow = boolval(c('Vanilla.EnableCategoryFollowing')) && $groupModel->canFollowGroup($group);
6363
$canWatch = $groupModel->canWatchGroup($group);
@@ -69,7 +69,7 @@ function getGroupOptionsDropdown($group = null) {
6969
->addLinkIf($canDelete, t('Delete'), '/group/delete?groupid='.$groupID, 'delete', 'DeleteGroup Popup')
7070
->addLinkIf($canManageCategories, t('Add Category'), '/group/category/'.$groupID, 'add_category', 'AddCategory Popup')
7171
->addLinkIf($canInviteMember, t('Invite Member'), '/group/invite/'.$groupID, 'invite','InviteGroup Popup')
72-
->addLinkIf($canManageMembers, t('Manage Members'), '/group/members/'.$groupID, 'manage')
72+
// ->addLinkIf($canManageMembers, t('Manage Members'), '/group/members/'.$groupID, 'manage')
7373
->addLinkIf($canFollow && !$hasFollowed, t('Follow Categories'), '/group/follow/'.$groupID, 'follow','FollowGroup Popup')
7474
->addLinkIf($hasFollowed, t('Unfollow Categories'), '/group/unfollow/'.$groupID, 'unfollow', 'UnfollowGroup Popup')
7575
->addLinkIf($canWatch && !$hasWatched, t('Watch Categories'), '/group/watch/'.$groupID, 'watch','WatchGroup Popup')
@@ -127,23 +127,25 @@ function writeGroupMembersWithDetails($members, $group) {
127127
$dateInserted = val('DateInserted', $memberObj);
128128
?>
129129
<li id="Member_<?php echo $memberID?>" class="Item hasPhotoWrap">
130-
<?php echo userPhoto($member, 'PhotoWrap'); ?>
131-
<span class="Options">
132-
<div class="Buttons ">
133-
<?php
134-
if($groupModel->canChangeGroupRole($group)) {
135-
if($memberID != $ownerID) {
136-
if ($role === GroupModel::ROLE_LEADER) {
137-
echo anchor('Make Member', '/group/setrole/' . $groupID . '?role=' . GroupModel::ROLE_MEMBER . '&memberid=' . $memberID, 'Button MakeMember', '');
138-
} else {
139-
echo anchor('Make Leader', '/group/setrole/' . $groupID . '?role=' . GroupModel::ROLE_LEADER . '&memberid=' . $memberID, 'Button MakeLeader', '');
140-
}
141-
echo anchor('Remove', '/group/removemember/' . $groupID . '?memberid=' . $memberID, 'Button DeleteGroupMember', '');
142-
}
143-
}
130+
<?php echo userPhoto($member, 'PhotoWrap ProfilePhotoMedium');
131+
/*
132+
if($groupModel->canChangeGroupRole($group)) {
133+
134+
echo '<span class="Options">';
135+
echo '<div class="Buttons ">';
136+
if($memberID != $ownerID) {
137+
if ($role === GroupModel::ROLE_LEADER) {
138+
echo anchor('Make Member', '/group/setrole/' . $groupID . '?role=' . GroupModel::ROLE_MEMBER . '&memberid=' . $memberID, 'Button MakeMember', '');
139+
} else {
140+
echo anchor('Make Leader', '/group/setrole/' . $groupID . '?role=' . GroupModel::ROLE_LEADER . '&memberid=' . $memberID, 'Button MakeLeader', '');
141+
}
142+
echo anchor('Remove', '/group/removemember/' . $groupID . '?memberid=' . $memberID, 'Button DeleteGroupMember', '');
143+
}
144+
echo '</div>';
145+
echo '</span>';
146+
}
147+
*/
144148
?>
145-
</div>
146-
</span>
147149
<div class="ItemContent">
148150
<div class="Title" role="heading" aria-level="3">
149151
<?php echo userAnchor($member, 'Username'); ?>
@@ -234,10 +236,14 @@ function writeGroupHeader($group, $showDetails = false, $owner = null, $leaders
234236
<div class="TableCell Cell1">Created on</div>
235237
<div class="TableCell Cell2"><?php echo $group->DateInserted; ?></div>
236238
</div>
237-
<div class="MItem TableRow Last">
239+
<div class="MItem TableRow">
238240
<div class="TableCell Cell1">Privacy</div>
239241
<div class="TableCell Cell2"><?php echo $group->Privacy; ?></div>
240242
</div>
243+
<div class="MItem TableRow Last">
244+
<div class="TableCell Cell1">Archived</div>
245+
<div class="TableCell Cell2"><?php echo $group->Archived == 1? 'yes': 'no'; ?></div>
246+
</div>
241247
</div>
242248
</div>
243249
<?php }?>

0 commit comments

Comments
 (0)