move challenge fee to payment detail

Author: vas3a

src/domain/Challenge.ts

@@ -961,6 +961,7 @@ class ChallengeDomain extends CoreOperations<Challenge, CreateChallengeInput> {
           installmentNumber: 1,
           currency: "USD",
           billingAccount: `${billingAccountId}`,
+          challengeFee: totalAmount * challengeMarkup,
         },
       ];
 
@@ -985,7 +986,6 @@ class ChallengeDomain extends CoreOperations<Challenge, CreateChallengeInput> {
         attributes: {
           billingAccountId,
           payroll: false,
-          challengeFee: totalAmount * challengeMarkup,
         },
       };
 

src/util/FinanceApi.ts

@@ -6,6 +6,7 @@ export interface PaymentDetail {
   installmentNumber: number;
   currency: string;
   billingAccount: string;
+  challengeFee: number;
 }
 
 export interface PaymentPayload {
@@ -18,7 +19,6 @@ export interface PaymentPayload {
   externalId: string;
   attributes?: {
     [key: string]: string | boolean | number;
-    challengeFee: number;
   };
   details: PaymentDetail[];
 }