From 595ff748c28060346b5b1dd6c7cef08323a12b63 Mon Sep 17 00:00:00 2001
From: gets0ul <gets0ul@gmail.com>
Date: Fri, 16 Oct 2020 00:46:52 +0700
Subject: [PATCH] fix: no challenges message when sorting all challenges

---
 .../components/challenge-listing/Listing/Bucket/index.jsx   | 2 +-
 src/shared/components/challenge-listing/Listing/index.jsx   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/shared/components/challenge-listing/Listing/Bucket/index.jsx b/src/shared/components/challenge-listing/Listing/Bucket/index.jsx
index 371326cc55..abf6bda83b 100644
--- a/src/shared/components/challenge-listing/Listing/Bucket/index.jsx
+++ b/src/shared/components/challenge-listing/Listing/Bucket/index.jsx
@@ -184,7 +184,7 @@ export default function Bucket({
       {placeholders}
       {
       // (expandable || loadMore) && (expandable || !keepPlaceholders) && !loading && !expanded ? (
-        (expanding || expandable || loadMore) && !loading && !expanded ? (
+        (expanding || expandable || loadMore) && !loading && (expandable ? expanded : !expanded) ? (
           <a
             // href={`${challengesUrl}?${bucketQuery}`}
             href={`${challengesUrl}`}
diff --git a/src/shared/components/challenge-listing/Listing/index.jsx b/src/shared/components/challenge-listing/Listing/index.jsx
index a7441474d6..479684a962 100644
--- a/src/shared/components/challenge-listing/Listing/index.jsx
+++ b/src/shared/components/challenge-listing/Listing/index.jsx
@@ -182,8 +182,7 @@ function Listing({
     );
   };
 
-  if (!expanding && (activeBucket !== BUCKETS.ALL)
-  && (activeBucket !== BUCKETS.SAVED_FILTER)) {
+  if ((activeBucket !== BUCKETS.SAVED_FILTER)) {
     return (
       <div styleName="challengeCardContainer">
         {getBucket(activeBucket, true)}
@@ -207,7 +206,8 @@ function Listing({
   // }
   const loading = loadingMyChallenges
     || loadingOpenForRegistrationChallenges
-    || loadingOnGoingChallenges;
+    || loadingOnGoingChallenges
+    || loadingAllChallenges;
   const placeholders = [];
   if (challenges.length > 0 || (activeBucket === BUCKETS.ALL && allChallenges.length > 0)) {
     return (