From 6520f19c326a2cdc76080d0f2aaa4948957833c9 Mon Sep 17 00:00:00 2001 From: rashmi73 <41687423+rashmi73@users.noreply.github.com> Date: Sat, 12 Sep 2020 16:03:41 +0530 Subject: [PATCH 1/5] Update ChallengeTags.jsx --- src/shared/components/challenge-detail/Header/ChallengeTags.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx index bbea412300..bc9ef6c5b6 100644 --- a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx +++ b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx @@ -62,7 +62,7 @@ export default function ChallengeTags(props) { challengeType && ( setImmediate(() => setChallengeListingFilter(challengeType.id)) + onClick={() => setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) } to={`${challengesUrl}?filter[types][0]=${encodeURIComponent(challengeType.id)}`} > From 334596ee7fbd9d74b8320c66bc9325cbaae94f33 Mon Sep 17 00:00:00 2001 From: rashmi73 <41687423+rashmi73@users.noreply.github.com> Date: Sat, 12 Sep 2020 17:02:27 +0530 Subject: [PATCH 2/5] Update ChallengeTags.jsx --- .../components/challenge-detail/Header/ChallengeTags.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx index bc9ef6c5b6..9e660d1a05 100644 --- a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx +++ b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx @@ -62,7 +62,8 @@ export default function ChallengeTags(props) { challengeType && ( setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) + onClick={() => + setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) } to={`${challengesUrl}?filter[types][0]=${encodeURIComponent(challengeType.id)}`} > From 5c34df6c819954c31b74b848188ddbcbac9c323a Mon Sep 17 00:00:00 2001 From: rashmi73 Date: Thu, 17 Sep 2020 02:24:16 +0530 Subject: [PATCH 3/5] tests fix --- .../components/challenge-detail/Header/ChallengeTags.jsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx index 9e660d1a05..d2e29df8c0 100644 --- a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx +++ b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx @@ -62,8 +62,9 @@ export default function ChallengeTags(props) { challengeType && ( - setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) + onClick={() => { + return setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) + } } to={`${challengesUrl}?filter[types][0]=${encodeURIComponent(challengeType.id)}`} > From ba22b45b6b2f5723387781070e5ad2ede88c0d84 Mon Sep 17 00:00:00 2001 From: rashmi73 Date: Thu, 17 Sep 2020 02:47:52 +0530 Subject: [PATCH 4/5] test fix --- .../components/challenge-detail/Header/ChallengeTags.jsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx index d2e29df8c0..e128b7dc6b 100644 --- a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx +++ b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx @@ -62,10 +62,7 @@ export default function ChallengeTags(props) { challengeType && ( { - return setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) - } - } + onClick={() => setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] }))} to={`${challengesUrl}?filter[types][0]=${encodeURIComponent(challengeType.id)}`} > {challengeType.name} From 3c2347a09b666f6e3a8e788ed10b9165df8ddc20 Mon Sep 17 00:00:00 2001 From: rashmi73 Date: Thu, 17 Sep 2020 03:02:19 +0530 Subject: [PATCH 5/5] test fix --- .../components/challenge-detail/Header/ChallengeTags.jsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx index e128b7dc6b..67c51669db 100644 --- a/src/shared/components/challenge-detail/Header/ChallengeTags.jsx +++ b/src/shared/components/challenge-detail/Header/ChallengeTags.jsx @@ -62,7 +62,10 @@ export default function ChallengeTags(props) { challengeType && ( setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] }))} + onClick={() => ( + setImmediate(() => setChallengeListingFilter({ types: [challengeType.id] })) + ) + } to={`${challengesUrl}?filter[types][0]=${encodeURIComponent(challengeType.id)}`} > {challengeType.name}