From d154da90650da5690d85b69410d9ecd50d1fbca3 Mon Sep 17 00:00:00 2001 From: Afrisal Yodi Purnama Date: Tue, 23 Jul 2019 20:20:09 +0700 Subject: [PATCH 1/4] Put Banner, Nav, Main, Contentinfo Landmark --- src/shared/components/Dashboard/index.jsx | 2 +- .../components/ProfilePage/Stats/index.jsx | 2 +- src/shared/components/ProfilePage/index.jsx | 2 +- .../ReviewOpportunityDetailsPage/index.jsx | 2 +- .../components/SubmissionPage/index.jsx | 2 +- .../components/TopcoderFooter/index.jsx | 28 +++++++++---------- .../components/TopcoderHeader/index.jsx | 4 ++- .../containers/SubmissionManagement/index.jsx | 2 +- .../containers/challenge-detail/index.jsx | 2 +- .../challenge-listing/Listing/index.jsx | 2 +- 10 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/shared/components/Dashboard/index.jsx b/src/shared/components/Dashboard/index.jsx index 939612ccd0..3b885cbc6f 100644 --- a/src/shared/components/Dashboard/index.jsx +++ b/src/shared/components/Dashboard/index.jsx @@ -44,7 +44,7 @@ export default function Dashboard({ }) { return (
-
+
+
diff --git a/src/shared/components/ProfilePage/index.jsx b/src/shared/components/ProfilePage/index.jsx index 9000a6d4c8..28bc7d6e84 100644 --- a/src/shared/components/ProfilePage/index.jsx +++ b/src/shared/components/ProfilePage/index.jsx @@ -167,7 +167,7 @@ class ProfilePage extends React.Component { /> ) } -
+
(
-
+

diff --git a/src/shared/components/SubmissionPage/index.jsx b/src/shared/components/SubmissionPage/index.jsx index b0dd3aa986..73742c13e2 100644 --- a/src/shared/components/SubmissionPage/index.jsx +++ b/src/shared/components/SubmissionPage/index.jsx @@ -40,7 +40,7 @@ function SubmissionsPage(props) { return (
-
+
- + +
diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index cf6c9727ec..77b0295c62 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -337,6 +337,7 @@ export default class TopcoderHeader extends React.Component { return (
{ this.headerRoot = div; }} onMouseLeave={() => { if (openedMenu) { @@ -351,7 +352,7 @@ export default class TopcoderHeader extends React.Component { -
    { this.mainMenu = ul; }}> +
      { this.mainMenu = ul; }}> {mainMenu}
    @@ -401,6 +402,7 @@ export default class TopcoderHeader extends React.Component { styleName="search-field" > { this.searchInput = input; }} onKeyPress={(event) => { if (event.key === 'Enter') { diff --git a/src/shared/containers/SubmissionManagement/index.jsx b/src/shared/containers/SubmissionManagement/index.jsx index ea92f94ae9..c09ffe36a8 100644 --- a/src/shared/containers/SubmissionManagement/index.jsx +++ b/src/shared/containers/SubmissionManagement/index.jsx @@ -81,7 +81,7 @@ class SubmissionManagementPageContainer extends React.Component { return (
    -
    +
    {!isEmpty && ( -
    +
    { Boolean(isEmpty) && (
    Challenge # diff --git a/src/shared/containers/challenge-listing/Listing/index.jsx b/src/shared/containers/challenge-listing/Listing/index.jsx index 61bc3939ed..0a934ee595 100644 --- a/src/shared/containers/challenge-listing/Listing/index.jsx +++ b/src/shared/containers/challenge-listing/Listing/index.jsx @@ -237,7 +237,7 @@ export class ListingContainer extends React.Component { } return ( -
    +
    Date: Tue, 23 Jul 2019 20:41:35 +0700 Subject: [PATCH 2/4] Challenge listing search aria role. --- .../challenge-listing/Filters/ChallengeSearchBar/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/challenge-listing/Filters/ChallengeSearchBar/index.jsx b/src/shared/components/challenge-listing/Filters/ChallengeSearchBar/index.jsx index fa3989b7f3..5c7b69780a 100644 --- a/src/shared/components/challenge-listing/Filters/ChallengeSearchBar/index.jsx +++ b/src/shared/components/challenge-listing/Filters/ChallengeSearchBar/index.jsx @@ -24,7 +24,7 @@ export default function ChallengeSearchBar({ setQuery, }) { return ( -
    +
    setQuery(event.target.value)} onKeyPress={event => (event.key === 'Enter' ? onSearch(query.trim()) : null)} From 6e5fc0108e10fd53fb622e20b6a28321c64019e5 Mon Sep 17 00:00:00 2001 From: Afrisal Yodi Purnama Date: Wed, 24 Jul 2019 09:03:46 +0700 Subject: [PATCH 3/4] Fix lint. --- src/shared/components/TopcoderHeader/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index 77b0295c62..6f5e6eb523 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -388,6 +388,7 @@ export default class TopcoderHeader extends React.Component { trigger={activeTrigger} />
    { /* False when cursor leaves from the sub-menu to the element that has @@ -402,7 +403,6 @@ export default class TopcoderHeader extends React.Component { styleName="search-field" > { this.searchInput = input; }} onKeyPress={(event) => { if (event.key === 'Enter') { From efcaeebf8cb958a84c37bd1d38ced95db00626a7 Mon Sep 17 00:00:00 2001 From: Afrisal Yodi Purnama Date: Wed, 24 Jul 2019 10:44:13 +0700 Subject: [PATCH 4/4] Update snapshots. --- .../ProfilePage/__snapshots__/index.jsx.snap | 2 + .../__snapshots__/index.jsx.snap | 9 ++ .../__snapshots__/TopcoderFooter.jsx.snap | 87 +++++++++---------- .../__snapshots__/ChallengeSearchBar.jsx.snap | 2 + 4 files changed, 56 insertions(+), 44 deletions(-) diff --git a/__tests__/shared/components/ProfilePage/__snapshots__/index.jsx.snap b/__tests__/shared/components/ProfilePage/__snapshots__/index.jsx.snap index 7e222a6b27..fb48f813bb 100644 --- a/__tests__/shared/components/ProfilePage/__snapshots__/index.jsx.snap +++ b/__tests__/shared/components/ProfilePage/__snapshots__/index.jsx.snap @@ -6,6 +6,7 @@ exports[`renders a full Profile correctly 1`] = ` >
      • diff --git a/__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeSearchBar.jsx.snap b/__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeSearchBar.jsx.snap index cac458c105..90bb23241e 100644 --- a/__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeSearchBar.jsx.snap +++ b/__tests__/shared/components/challenge-listing/Filters/__snapshots__/ChallengeSearchBar.jsx.snap @@ -3,6 +3,7 @@ exports[`Matches shallow shapshot 1`] = `