From cd9a2f64420e1e4353d5c1cb3bb86107cab745d0 Mon Sep 17 00:00:00 2001 From: Anwar Sadath Date: Mon, 22 Jul 2019 16:07:14 +0530 Subject: [PATCH 1/5] Fix #2831 [MSFT-135] Eligible event section content is not read-out by the screen reader --- src/assets/images/tco19_logo_black.svg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/assets/images/tco19_logo_black.svg b/src/assets/images/tco19_logo_black.svg index f47126c6a4..26e54957e8 100644 --- a/src/assets/images/tco19_logo_black.svg +++ b/src/assets/images/tco19_logo_black.svg @@ -1,7 +1,7 @@ - 4B44DA3B-3D5C-451B-9F77-812298E66E52 + TCO19 Created with sketchtool. From 43494aeb6dcc4332693b75493cf59230e04f912e Mon Sep 17 00:00:00 2001 From: Anwar Sadath Date: Mon, 22 Jul 2019 22:20:07 +0530 Subject: [PATCH 2/5] Fix #2823 [MSFT-125] Sample challenge page: Screen reader reads the registrants information in a textual format and not in a tabular format --- .../components/challenge-detail/Registrants/index.jsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/shared/components/challenge-detail/Registrants/index.jsx b/src/shared/components/challenge-detail/Registrants/index.jsx index 9b82966747..24089333aa 100644 --- a/src/shared/components/challenge-detail/Registrants/index.jsx +++ b/src/shared/components/challenge-detail/Registrants/index.jsx @@ -99,12 +99,12 @@ Round 1 Submitted Date return (
-
- +
+ {r.handle}
-
+
Registration Date
@@ -113,7 +113,7 @@ Registration Date { twoRounds && ( -
+
Round 1 Submitted Date
@@ -129,7 +129,7 @@ Round 1 Submitted Date
) } -
+
{twoRounds ? 'Round 2 ' : ''} Submitted Date From 081295d6c0a500ed7657023be55eb49cd7f14421 Mon Sep 17 00:00:00 2001 From: Anwar Sadath Date: Mon, 22 Jul 2019 23:31:19 +0530 Subject: [PATCH 3/5] Fix #2911 [MSFT-264] Keyboard access tab operational missing --- src/client/styles.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/styles.scss b/src/client/styles.scss index 41ddcb7d3e..d66601079e 100644 --- a/src/client/styles.scss +++ b/src/client/styles.scss @@ -3,6 +3,6 @@ * the page by Topcoder accounts-app. */ #tc-accounts-iframe { border: none; - display: block; + display: none; } } From 89d1b1ad60bf39d020e439d9cc8fb4f6bbfb2442 Mon Sep 17 00:00:00 2001 From: Anwar Sadath Date: Tue, 23 Jul 2019 11:42:24 +0530 Subject: [PATCH 4/5] Fix #2806 [MSFT-102] Challenges page: Screen readers announce the details of the challenge in an incorrect order. --- .../challenge-listing/ChallengeCard/Prize/index.jsx | 8 ++++---- .../challenge-listing/ChallengeCard/Prize/style.scss | 6 ++++++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/shared/components/challenge-listing/ChallengeCard/Prize/index.jsx b/src/shared/components/challenge-listing/ChallengeCard/Prize/index.jsx index 3e6c3aa8e5..f938ceaf8c 100644 --- a/src/shared/components/challenge-listing/ChallengeCard/Prize/index.jsx +++ b/src/shared/components/challenge-listing/ChallengeCard/Prize/index.jsx @@ -19,16 +19,16 @@ export default function Prize({ withoutTooltip, }) { const component = ( -
+
+
+ {label} +
{prizeUnitSymbol} {totalPrize.toLocaleString()}
-
- {label} -
); if (withoutTooltip) return component; diff --git a/src/shared/components/challenge-listing/ChallengeCard/Prize/style.scss b/src/shared/components/challenge-listing/ChallengeCard/Prize/style.scss index 1ed78522b6..f00cfee222 100644 --- a/src/shared/components/challenge-listing/ChallengeCard/Prize/style.scss +++ b/src/shared/components/challenge-listing/ChallengeCard/Prize/style.scss @@ -1,5 +1,10 @@ @import "~styles/mixins"; +.prize-wrapper { + display: flex; + flex-direction: column; +} + .label { cursor: default; padding: 0 (2 * $base-unit); @@ -7,6 +12,7 @@ font-size: 10px; color: $tc-gray-70; white-space: nowrap; + order: 2; @include xs-to-sm { display: inline-block; From 515f3941aa16cff7611e5d4ad35fbb4eb225f2cc Mon Sep 17 00:00:00 2001 From: Anwar Sadath Date: Tue, 23 Jul 2019 13:59:41 +0530 Subject: [PATCH 5/5] Fix #2824 [MSFT-126] Sample challenge page: There is a Question mark next to the content under the headings 'final review' and 'approval'. A message appears when the mouse is hovered over the ?. The tooltip is not keyboard accessible. --- .../challenge-detail/Specification/SideBar/index.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/shared/components/challenge-detail/Specification/SideBar/index.jsx b/src/shared/components/challenge-detail/Specification/SideBar/index.jsx index acede5ae5e..a7b8870f32 100644 --- a/src/shared/components/challenge-detail/Specification/SideBar/index.jsx +++ b/src/shared/components/challenge-detail/Specification/SideBar/index.jsx @@ -108,7 +108,7 @@ Final Review: {reviewTypeTitle} - +
?
@@ -119,7 +119,7 @@ Approval: User Sign-Off - +
?