From 0adf8571cf3498ef1e89b046dbd37d1dc7f7728b Mon Sep 17 00:00:00 2001
From: r0hit-gupta <rohit1997gupta@gmail.com>
Date: Fri, 19 Jul 2019 00:51:06 +0530
Subject: [PATCH 1/2] changes for #2829

---
 .../challenge-detail/Header/TabSelector/index.jsx      | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx
index af2d82cf83..44dc510d88 100644
--- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx
+++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx
@@ -73,6 +73,8 @@ export default function ChallengeViewSelector(props) {
       <div styleName="mask right" />
       <div styleName="challenge-view-selector">
         <a
+          tabIndex="0"
+          role="link"
           onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.DETAILS); }}
           onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.DETAILS); }}
           styleName={getSelectorStyle(selectedView, DETAIL_TABS.DETAILS)}
@@ -82,6 +84,8 @@ DETAILS
         {
           numRegistrants ? (
             <a
+              tabIndex="0"
+              role="link"
               onClick={(e) => {
                 handleSelectorClicked(e, DETAIL_TABS.REGISTRANTS);
               }}
@@ -100,6 +104,8 @@ REGISTRANTS (
           trackLower === 'design' && checkpointCount > 0
           && (
           <a
+            tabIndex="0"
+            role="link"
             onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.CHECKPOINTS); }}
             onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.CHECKPOINTS); }}
             styleName={getSelectorStyle(selectedView, DETAIL_TABS.CHECKPOINTS)}
@@ -113,6 +119,8 @@ CHECKPOINTS (
         {
           numSubmissions ? (
             <a
+              tabIndex="0"
+              role="link"
               onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.SUBMISSIONS); }}
               onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.SUBMISSIONS); }}
               styleName={getSelectorStyle(selectedView, DETAIL_TABS.SUBMISSIONS)}
@@ -126,6 +134,8 @@ SUBMISSIONS (
         {
           numWinners ? (
             <a
+              tabIndex="0"
+              role="link"
               onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.WINNERS); }}
               onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.WINNERS); }}
               styleName={getSelectorStyle(selectedView, DETAIL_TABS.WINNERS)}

From d865e0a0c2b2ec7e9518ded16f79cf500bd99f4f Mon Sep 17 00:00:00 2001
From: r0hit-gupta <rohit1997gupta@gmail.com>
Date: Fri, 19 Jul 2019 01:18:29 +0530
Subject: [PATCH 2/2] changes for #2822

---
 .../challenge-detail/Header/TabSelector/index.jsx | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx
index 44dc510d88..d9c2464669 100644
--- a/src/shared/components/challenge-detail/Header/TabSelector/index.jsx
+++ b/src/shared/components/challenge-detail/Header/TabSelector/index.jsx
@@ -74,7 +74,8 @@ export default function ChallengeViewSelector(props) {
       <div styleName="challenge-view-selector">
         <a
           tabIndex="0"
-          role="link"
+          role="tab"
+          aria-selected={selectedView === DETAIL_TABS.DETAILS}
           onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.DETAILS); }}
           onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.DETAILS); }}
           styleName={getSelectorStyle(selectedView, DETAIL_TABS.DETAILS)}
@@ -85,7 +86,8 @@ DETAILS
           numRegistrants ? (
             <a
               tabIndex="0"
-              role="link"
+              role="tab"
+              aria-selected={selectedView === DETAIL_TABS.REGISTRANTS}
               onClick={(e) => {
                 handleSelectorClicked(e, DETAIL_TABS.REGISTRANTS);
               }}
@@ -105,7 +107,8 @@ REGISTRANTS (
           && (
           <a
             tabIndex="0"
-            role="link"
+            role="tab"
+            aria-selected={selectedView === DETAIL_TABS.CHECKPOINTS}
             onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.CHECKPOINTS); }}
             onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.CHECKPOINTS); }}
             styleName={getSelectorStyle(selectedView, DETAIL_TABS.CHECKPOINTS)}
@@ -120,7 +123,8 @@ CHECKPOINTS (
           numSubmissions ? (
             <a
               tabIndex="0"
-              role="link"
+              role="tab"
+              aria-selected={selectedView === DETAIL_TABS.SUBMISSIONS}
               onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.SUBMISSIONS); }}
               onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.SUBMISSIONS); }}
               styleName={getSelectorStyle(selectedView, DETAIL_TABS.SUBMISSIONS)}
@@ -135,7 +139,8 @@ SUBMISSIONS (
           numWinners ? (
             <a
               tabIndex="0"
-              role="link"
+              role="tab"
+              aria-selected={selectedView === DETAIL_TABS.WINNERS}
               onClick={(e) => { handleSelectorClicked(e, DETAIL_TABS.WINNERS); }}
               onKeyPress={(e) => { handleSelectorClicked(e, DETAIL_TABS.WINNERS); }}
               styleName={getSelectorStyle(selectedView, DETAIL_TABS.WINNERS)}