From d4fb245b63ffc5ed5e5791d5acd7b62c2b2604c0 Mon Sep 17 00:00:00 2001 From: r0hit-gupta Date: Thu, 18 Jul 2019 23:35:30 +0530 Subject: [PATCH 1/4] changes for #2755 --- .../challenge-listing/Filters/FiltersSwitch/index.jsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx b/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx index 1c66563a41..7545761bf3 100644 --- a/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx +++ b/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx @@ -39,6 +39,8 @@ export default function FiltersSwitch({ return (
(onSwitch ? onSwitch(!active) : null)} onKeyPress={() => (onSwitch ? onSwitch(!active) : null)} From 9512530eb86374edff053f0d9fcab4e8024d2644 Mon Sep 17 00:00:00 2001 From: r0hit-gupta Date: Fri, 19 Jul 2019 14:22:31 +0530 Subject: [PATCH 2/4] update test --- .../Filters/__snapshots__/FiltersSwitch.jsx.snap | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap b/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap index e10d3de55d..775489ce8e 100644 --- a/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap +++ b/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap @@ -5,6 +5,8 @@ exports[`Matches shallow shapshot 1`] = ` className="tc-outline-btn name src-shared-components-challenge-listing-Filters-FiltersSwitch-___style__FiltersSwitch___2ixiH" onClick={[Function]} onKeyPress={[Function]} + role="button" + tabIndex="0" > Date: Fri, 19 Jul 2019 23:52:28 +0530 Subject: [PATCH 3/4] lint --- .../challenge-listing/Filters/FiltersSwitch/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx b/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx index 7545761bf3..a367f4dfa4 100644 --- a/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx +++ b/src/shared/components/challenge-listing/Filters/FiltersSwitch/index.jsx @@ -39,7 +39,7 @@ export default function FiltersSwitch({ return (
(onSwitch ? onSwitch(!active) : null)} From 24014ff3e5d50799617a61f7a3d01f0f22127448 Mon Sep 17 00:00:00 2001 From: r0hit-gupta Date: Fri, 19 Jul 2019 23:58:04 +0530 Subject: [PATCH 4/4] update test --- .../Filters/__snapshots__/FiltersSwitch.jsx.snap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap b/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap index 775489ce8e..af45bddba3 100644 --- a/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap +++ b/__tests__/shared/components/challenge-listing/Filters/__snapshots__/FiltersSwitch.jsx.snap @@ -6,7 +6,7 @@ exports[`Matches shallow shapshot 1`] = ` onClick={[Function]} onKeyPress={[Function]} role="button" - tabIndex="0" + tabIndex={0} >