From f516cc664ddd612861f497d5e9167b11bae6fc6d Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Thu, 18 Jul 2019 23:07:27 +0530 Subject: [PATCH 1/9] Update index.jsx --- src/shared/components/TopcoderHeader/index.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index 8bbadc5b75..1c381d2382 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -320,10 +320,11 @@ export default class TopcoderHeader extends React.Component { color: getRatingColor(_.get(normalizedProfile, 'maxRating.rating', 0)), }} styleName="user-menu-handle" + tabIndex={0} > {normalizedProfile.handle} - {userAvatar} + {userAvatar} ); } else { From d3f91ebea1915db36373142c87adee8c26379eaf Mon Sep 17 00:00:00 2001 From: prakashdurlabhji Date: Fri, 19 Jul 2019 14:35:02 +0530 Subject: [PATCH 2/9] fix --- .eslintrc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index ddc5f09737..0d7d67f4fe 100644 --- a/.eslintrc +++ b/.eslintrc @@ -2,7 +2,13 @@ "extends": "./node_modules/topcoder-react-utils/config/eslint/default.json", "rules": { "jsx-a11y/anchor-is-valid": false, - "import/no-cycle": [2, { "maxDepth": 1 }] + "import/no-cycle": [2, { "maxDepth": 1 }], + "jsx-a11y/no-noninteractive-tabindex": [ + { + "tags": ["h4", "div", "span"], + "roles": [], + }, + ] }, "env": { "browser": true From df5157c24b8d4de71b7d9883598c792d4d5851be Mon Sep 17 00:00:00 2001 From: prakashdurlabhji Date: Fri, 19 Jul 2019 14:59:44 +0530 Subject: [PATCH 3/9] test fix --- .../TopcoderHeader/__snapshots__/index.jsx.snap | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap index c8d287309f..c4002dc78e 100644 --- a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap +++ b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap @@ -612,16 +612,21 @@ exports[`Render with specified profile 1`] = ` "color": "#9D9FA0", } } + tabIndex={0} />
- + + +
Date: Fri, 19 Jul 2019 15:08:36 +0530 Subject: [PATCH 4/9] test fix --- .../TopcoderHeader/__snapshots__/index.jsx.snap | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap index c4002dc78e..637102591e 100644 --- a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap +++ b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap @@ -614,11 +614,11 @@ exports[`Render with specified profile 1`] = ` } tabIndex={0} /> -
- - -
+
+
Date: Fri, 26 Jul 2019 02:54:20 +0530 Subject: [PATCH 5/9] Update .eslintrc --- .eslintrc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.eslintrc b/.eslintrc index e30e979e48..00def584cd 100644 --- a/.eslintrc +++ b/.eslintrc @@ -3,12 +3,6 @@ "rules": { "jsx-a11y/anchor-is-valid": false, "import/no-cycle": [2, { "maxDepth": 1 }], - "jsx-a11y/no-noninteractive-tabindex": [ - { - "tags": ["h4", "div", "span"], - "roles": [], - }, - ], "react/prop-types": ["error", { "ignore": ["challenge","eventDetails","winner","bucket","theme","submissionObject","profile","communitiesList","meta","scoreboard","item","activeTrigger","menuItems","scoreboard"] }] }, "env": { From 084f2960adf1b9205debbf0363a9befbed003642 Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Fri, 26 Jul 2019 02:57:34 +0530 Subject: [PATCH 6/9] Update index.jsx --- src/shared/components/TopcoderHeader/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index 1dee423dcd..867fd4d968 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -324,7 +324,7 @@ export default class TopcoderHeader extends React.Component { > {normalizedProfile.handle}
- {userAvatar} + {userAvatar} ); } else { From 490754518eaf23f3b40ac5798f1c93bc4e040408 Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Fri, 26 Jul 2019 03:48:09 +0530 Subject: [PATCH 7/9] Update index.jsx --- src/shared/components/TopcoderHeader/index.jsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index 867fd4d968..9ba927a932 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -321,10 +321,11 @@ export default class TopcoderHeader extends React.Component { }} styleName="user-menu-handle" tabIndex={0} + role="button" > {normalizedProfile.handle} - {userAvatar} + {userAvatar} ); } else { @@ -376,6 +377,8 @@ export default class TopcoderHeader extends React.Component { } }} styleName="search-icon" + tabIndex="0" + role="button" > From 714ace5fe6c5ce95dfac50e1672d3f7ad28f3bd7 Mon Sep 17 00:00:00 2001 From: PrakashDurlabhji Date: Fri, 26 Jul 2019 04:03:04 +0530 Subject: [PATCH 8/9] Update index.jsx.snap --- .../TopcoderHeader/__snapshots__/index.jsx.snap | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap index 2e6ca4d4b2..f59932ed64 100644 --- a/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap +++ b/__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap @@ -81,6 +81,8 @@ exports[`Default render 1`] = ` onMouseEnter={[Function]} onMouseLeave={[Function]} onTouchStart={[Function]} + role="button" + tabIndex="0" >
Date: Sat, 27 Jul 2019 01:55:09 +0530 Subject: [PATCH 9/9] tests fix --- src/shared/components/TopcoderHeader/index.jsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/shared/components/TopcoderHeader/index.jsx b/src/shared/components/TopcoderHeader/index.jsx index cd70147d11..e8363897d0 100644 --- a/src/shared/components/TopcoderHeader/index.jsx +++ b/src/shared/components/TopcoderHeader/index.jsx @@ -380,8 +380,6 @@ export default class TopcoderHeader extends React.Component { } }} styleName="search-icon" - tabIndex="0" - role="button" >