From 04f24ffda4c229c4509c44c4aab2726d5acbe082 Mon Sep 17 00:00:00 2001 From: rashmi73 Date: Fri, 2 Nov 2018 03:11:46 +0530 Subject: [PATCH 1/2] issue_1732 fixed linting issues resolved --- .eslintrc | 47 ++++++++++++++++++- .../Specification/SideBar/index.jsx | 2 +- src/shared/reducers/contentful/index.js | 4 +- 3 files changed, 49 insertions(+), 4 deletions(-) diff --git a/.eslintrc b/.eslintrc index 7020faae69..43e315fd7d 100644 --- a/.eslintrc +++ b/.eslintrc @@ -1,6 +1,51 @@ { "extends": "./node_modules/topcoder-react-utils/config/eslint/default.json", "rules": { - "jsx-a11y/anchor-is-valid": false + "jsx-a11y/anchor-is-valid": false, + "jsx-a11y/label-has-for": [ + 2, + { + "components": [ + "Label" + ], + "required": { + "some": [ + "nesting", + "id" + ] + }, + "allowChildren": false + } + ], + "jsx-a11y/label-has-associated-control": [ + 2, + { + "labelComponents": [ + "CustomLabel" + ], + "labelAttributes": [ + "inputLabel" + ], + "controlComponents": [ + "CustomInput" + ], + "depth": 3 + } + ], + "no-unused-vars": "off", + "no-undef": "off", + "react/jsx-no-undef": [ + false + ], + "react/require-default-props": [ + false + ], + "linebreak-style": 0, + "global-require": 0, + "eslint linebreak-style": [ + 0, + "error", + "windows" + ] } } \ No newline at end of file diff --git a/src/shared/components/challenge-detail/Specification/SideBar/index.jsx b/src/shared/components/challenge-detail/Specification/SideBar/index.jsx index 45fb5defe1..1ef41dc65d 100644 --- a/src/shared/components/challenge-detail/Specification/SideBar/index.jsx +++ b/src/shared/components/challenge-detail/Specification/SideBar/index.jsx @@ -355,5 +355,5 @@ SideBar.propTypes = { isDevelop: PT.bool, environment: PT.string, codeRepo: PT.string, - isMM:PT.bool, + isMM: PT.bool, }; diff --git a/src/shared/reducers/contentful/index.js b/src/shared/reducers/contentful/index.js index 098348ad3d..1dc2222d4f 100644 --- a/src/shared/reducers/contentful/index.js +++ b/src/shared/reducers/contentful/index.js @@ -19,10 +19,10 @@ import _ from 'lodash'; import actions from 'actions/contentful'; -import space from './space'; import { errors, logger } from 'topcoder-react-lib'; import { config } from 'topcoder-react-utils'; +import space from './space'; const { fireErrorMessage } = errors; @@ -58,7 +58,7 @@ function create(init) { if (!validActions.has(action.type)) return state; const { error, payload } = action; - + const newState = _.clone(state); const spaceName = payload.spaceName || config.CONTENTFUL.DEFAULT_SPACE_NAME; const environment = payload.environment || config.CONTENTFUL.DEFAULT_ENVIRONMENT; From dd6ce45f0eff4d9795a65c4fe4aca1895d05e4a5 Mon Sep 17 00:00:00 2001 From: rashmi73 Date: Fri, 2 Nov 2018 03:30:08 +0530 Subject: [PATCH 2/2] issue_1732 scss linting fixed --- .../challenge-detail/Specification/SideBar/styles.scss | 1 - src/shared/components/challenge-detail/Submissions/style.scss | 1 + .../tc-communities/communities/blockchain/Home/style.scss | 1 - .../components/tc-communities/communities/iot/About/style.scss | 1 - .../tc-communities/communities/iot/GetStarted/style.scss | 1 - .../components/tc-communities/communities/iot/Home/style.scss | 1 - .../components/tc-communities/communities/tco19/Home/style.scss | 1 - 7 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/shared/components/challenge-detail/Specification/SideBar/styles.scss b/src/shared/components/challenge-detail/Specification/SideBar/styles.scss index 168149efd0..438ad98832 100644 --- a/src/shared/components/challenge-detail/Specification/SideBar/styles.scss +++ b/src/shared/components/challenge-detail/Specification/SideBar/styles.scss @@ -177,4 +177,3 @@ margin-bottom: 3 * $base-unit; } } - diff --git a/src/shared/components/challenge-detail/Submissions/style.scss b/src/shared/components/challenge-detail/Submissions/style.scss index b061ac435d..b43fb5e774 100644 --- a/src/shared/components/challenge-detail/Submissions/style.scss +++ b/src/shared/components/challenge-detail/Submissions/style.scss @@ -153,6 +153,7 @@ @include xs-to-sm { display: none; } + .handle { color: $tc-dark-blue-110; } diff --git a/src/shared/components/tc-communities/communities/blockchain/Home/style.scss b/src/shared/components/tc-communities/communities/blockchain/Home/style.scss index 9b6b6c4d0d..e4bd7a5666 100644 --- a/src/shared/components/tc-communities/communities/blockchain/Home/style.scss +++ b/src/shared/components/tc-communities/communities/blockchain/Home/style.scss @@ -55,4 +55,3 @@ padding: 6px 0; } } - diff --git a/src/shared/components/tc-communities/communities/iot/About/style.scss b/src/shared/components/tc-communities/communities/iot/About/style.scss index 9b6b6c4d0d..e4bd7a5666 100644 --- a/src/shared/components/tc-communities/communities/iot/About/style.scss +++ b/src/shared/components/tc-communities/communities/iot/About/style.scss @@ -55,4 +55,3 @@ padding: 6px 0; } } - diff --git a/src/shared/components/tc-communities/communities/iot/GetStarted/style.scss b/src/shared/components/tc-communities/communities/iot/GetStarted/style.scss index 9b6b6c4d0d..e4bd7a5666 100644 --- a/src/shared/components/tc-communities/communities/iot/GetStarted/style.scss +++ b/src/shared/components/tc-communities/communities/iot/GetStarted/style.scss @@ -55,4 +55,3 @@ padding: 6px 0; } } - diff --git a/src/shared/components/tc-communities/communities/iot/Home/style.scss b/src/shared/components/tc-communities/communities/iot/Home/style.scss index 9b6b6c4d0d..e4bd7a5666 100644 --- a/src/shared/components/tc-communities/communities/iot/Home/style.scss +++ b/src/shared/components/tc-communities/communities/iot/Home/style.scss @@ -55,4 +55,3 @@ padding: 6px 0; } } - diff --git a/src/shared/components/tc-communities/communities/tco19/Home/style.scss b/src/shared/components/tc-communities/communities/tco19/Home/style.scss index 9b6b6c4d0d..e4bd7a5666 100644 --- a/src/shared/components/tc-communities/communities/tco19/Home/style.scss +++ b/src/shared/components/tc-communities/communities/tco19/Home/style.scss @@ -55,4 +55,3 @@ padding: 6px 0; } } -