Skip to content

[$25] textbox validation missing #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LieutenantRoger opened this issue Nov 12, 2021 · 39 comments
Closed

[$25] textbox validation missing #5783

LieutenantRoger opened this issue Nov 12, 2021 · 39 comments

Comments

@LieutenantRoger
Copy link
Collaborator

Steps to Reproduce

Open the link https://www.topcoder.com/settings/profile





click First name enter as @#$

Actual Result(s)

invalid input accepted

Expected Result(s)

Should not allow invalid input bandicam_2021-10-22_20-20-02-835

bandicam_2021-10-22_20-20-14-092






Environment Details

Device(s):
Laptop

Operating System:
Windows 10

Browser:
Firefox 93

screenshot:

@LieutenantRoger LieutenantRoger added Enhancement Functional P2 Important (resolve within 3 days) Valid FE labels Nov 12, 2021
@LieutenantRoger LieutenantRoger changed the title textbox validation missing [$25] textbox validation missing Nov 15, 2021
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/99759258-ad36-46de-becf-922c1391a282 has been created for this ticket.

This is an automated message for lieutenantroger via Topcoder X

@eisbilir
Copy link
Member

@bug-bash-helper assign

@bug-bash-helper
Copy link

@eisbilir ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/99759258-ad36-46de-becf-922c1391a282 has been assigned to eisbilir.

This is an automated message for lieutenantroger via Topcoder X

1 similar comment
@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/99759258-ad36-46de-becf-922c1391a282 has been assigned to eisbilir.

This is an automated message for lieutenantroger via Topcoder X

@bug-bash-hunt-helper
Copy link

@eisbilir ✅ you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@eisbilir
Copy link
Member

@bug-bash-helper unassign

@bug-bash-helper
Copy link

@eisbilir ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

1 similar comment
@bug-bash-hunt-helper
Copy link

@eisbilir ✅ you have been unassigned from this issue.

Now you may pick up another issue which is open for pickup if you like to.

@LieutenantRoger
Copy link
Collaborator Author

Challenge https://www.topcoder.com/challenges/99759258-ad36-46de-becf-922c1391a282 eisbilir has been unassigned.

This is an automated message for lieutenantroger via Topcoder X

@codejamtc
Copy link
Collaborator

Now the symbols are not accepted

bandicam 2021-11-17 15-21-25-393

@codejamtc codejamtc added this to the v1.14.3 milestone Nov 19, 2021
@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger @codejamtc , do you think we should allow space? At present we only allow these a-zA-Z0-9,. ?

@LieutenantRoger
Copy link
Collaborator Author

Hmmm, probably not good to have space for FirstName, do we have member having space in the firstName ?

@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger , you know when u have double names for first name like, John Fred Smith, or Mary Ann Smith.

@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger probably allow - too, as we have names like Ava-Mae, Ella-Ann etc

@LieutenantRoger
Copy link
Collaborator Author

ok, let's add 'space' and '-' as the allowed characters

@SathyaJayabal
Copy link
Collaborator

Verified on staging

@coderhacker
Copy link

this is passed on to production

5783.mp4

.

@LieutenantRoger
Copy link
Collaborator Author

payment proceeded directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants