Skip to content

Update Segment script #5313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajefts opened this issue Jan 22, 2021 · 11 comments
Closed

Update Segment script #5313

ajefts opened this issue Jan 22, 2021 · 11 comments
Assignees
Labels
Merged for QA P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production
Milestone

Comments

@ajefts
Copy link
Member

ajefts commented Jan 22, 2021

To comply with the latest security model, we need to update the segment script that is being included in the app.

Please refer to https://help.trychameleon.com/en/articles/4281577-using-secure-identity-verification-beta for the full explanation. We will be using the approach of modifying the want we include and call the Segment script.

Here is an example of the code that needs to be added/modified. Also see the attachment.

Screen Shot 2021-01-15 at 10 21 31 AM (1)

topcoder-segment-example.js (1).txt

Expected behavior
Notify @ajefts and @jswheeler once this is updated and they can verify if the change is functioning.

Note
The uid_hash can be obtained from @ajefts or @jswheeler AND needs to be included as an env var so it doesn't get publicly exposed.

@ajefts
Copy link
Member Author

ajefts commented Jan 22, 2021

fyi @Oanh-and-only-Oanh. Can we put this one on the P1 list?

@Oanh-and-only-Oanh Oanh-and-only-Oanh added the P1 Urgent (resolve within 24 hours) label Jan 22, 2021
@ajefts
Copy link
Member Author

ajefts commented Mar 15, 2021

Please see the comments on appirio-tech/connect-app#4282 for updated advice on how to implement this.

@luizrrodrigues
Copy link
Collaborator

@luizrrodrigues
Copy link
Collaborator

@ajefts @jswheeler Can you share the API Key in Slack please?

@luizrrodrigues luizrrodrigues modified the milestones: v1.8.5, v1.8.4 Apr 2, 2021
@luizrrodrigues luizrrodrigues self-assigned this Apr 2, 2021
@luizrrodrigues luizrrodrigues modified the milestones: v1.8.4, v1.8.5, v1.8.6 Apr 2, 2021
@luizrrodrigues luizrrodrigues modified the milestones: v1.8.7, v1.8.8 Apr 12, 2021
@ajefts
Copy link
Member Author

ajefts commented Apr 12, 2021

@luizrrodrigues Just checking when this one will be released? I keep seeing the milestone adjusted, but not sure what that means for the dates. Thanks.

@luizrrodrigues
Copy link
Collaborator

Hey @ajefts sorry delay on this. I forget to update status here, we deployed this to QA, but failed, implementation have an issue, I'll include this to next release Thursday.

@Oanh-and-only-Oanh
Copy link

thanks for the update @luizrrodrigues

@SathyaJayabal
Copy link
Collaborator

verified on staging

Network tab there are be 2 requests POST to https://api.segment.io/v1/i, one will send it to segment and one will send only to chameleon (with request payload { integrations: { All: false, Chameleon: true }})
Screenshot 2021-04-15 at 5 25 24 PM
Screenshot 2021-04-15 at 5 19 40 PM

Different accounts have different uid_hash values
Screenshot 2021-04-15 at 5 19 44 PM
Screenshot 2021-04-15 at 5 21 32 PM

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Apr 15, 2021

verified on staging(develop branch)

Network tab there ar 2 requests POST to https://api.segment.io/v1/i, one will send it to segment and one will send only to chameleon (with request payload { integrations: { All: false, Chameleon: true }})
Screenshot 2021-04-15 at 6 28 40 PM
Screenshot 2021-04-15 at 6 28 49 PM
Different accounts have different uid_hash values
Screenshot 2021-04-15 at 6 29 35 PM
Screenshot 2021-04-15 at 6 29 53 PM

@SathyaJayabal SathyaJayabal added the QA Pass in PROD Passed verification on Production label Apr 15, 2021
@SathyaJayabal
Copy link
Collaborator

verified on prod
Network tab there are 2 requests POST to https://api.segment.io/v1/i, one will send it to segment and one will send only to chameleon (with request payload { integrations: { All: false, Chameleon: true }})
Screenshot 2021-04-15 at 7 28 18 PM
Screenshot 2021-04-15 at 7 28 35 PM
Different accounts have different uid_hash values
Screenshot 2021-04-15 at 7 30 10 PM
Screenshot 2021-04-15 at 7 30 34 PM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal I'll reopen this one until @ajefts check.

@ajefts This one was release, please let me know if working well in your side.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged for QA P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production
Projects
None yet
Development

No branches or pull requests

4 participants