Skip to content

[$70] Add Appium Headspin skill #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oanh-and-only-Oanh opened this issue Dec 4, 2020 · 25 comments
Closed

[$70] Add Appium Headspin skill #5243

Oanh-and-only-Oanh opened this issue Dec 4, 2020 · 25 comments
Assignees
Labels
Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Dec 4, 2020

Requirement: 1) any member can add Appium Headspin skill but only those who complete challenge will receive tickmark 2) automatically add Appium Headspin skill to member profile with tickmark if they haven't already added the skill themselves.

No changes to existing functionality- we are adding a new skill

Have added the following details for the new skill Appium Headspin:

{
  "id": 472,
  "name": "Appium Headspin",
  "domain": "SKILLS",
  "status": "APPROVED",
  "categories": [
    "develop"
  ],
  "priority": 1,
  "synonyms": [
    "appium",
    "headspin"
  ],
  ...
}
@Oanh-and-only-Oanh Oanh-and-only-Oanh added Member Profiles P1 Urgent (resolve within 24 hours) labels Dec 4, 2020
@Oanh-and-only-Oanh
Copy link
Author

Add the skill Appium Headspin, icon needs to be updated by @Dara-K
@SathyaJayabal and @sandhiyakavi- Can you test it on dev environment
https://www.topcoder-dev.com/settings/profile#skills
Request you to test if the auto add Appium Headspin skill to member profile with tickmark works for a test member

@luizrrodrigues - We'll need to make prod changes once your ready
image

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Add Appium Headspin skill [$70] Add Appium Headspin skill Dec 4, 2020
@sandhiyakavi
Copy link
Collaborator

@luizrrodrigues @Oanh-and-only-Oanh Able to manually add the Appium Headspin skill but it is not available while creating the challenge in both WM as well as Direct.

image
image

@sandhiyakavi
Copy link
Collaborator

@Oanh-and-only-Oanh @luizrrodrigues The added Appium Headspin Technology is disappearing after sometime of activating the challenge.
Challenge: https://www.topcoder-dev.com/challenges/094ab749-f0cd-40b7-ba22-e8ab3a3b1a4f
Note: Checked in Prod, it is not disappearing.

Dev_headspin

dev_headspin_2

After sometime it disappears
dev_headspin_3

Tried to create challenge in direct but not able to create due to "operation failed in the contest service facade" error

headspin_direct_error

@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30159644 has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30159644 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Dec 22, 2020

@SathyaJayabal Icon added to Appium and Appium Headspin.

Deployed to QA env.

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues there are two appium skills
cc @sandhiyakavi
Screenshot 2020-12-22 at 10 01 10 AM

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Deployed to Stag env too.

This issue coming from API, but envs have 2 Appium skills. (118 and 556)

@sandhiyakavi
Copy link
Collaborator

@luizrrodrigues Same issue in Staging also

image

Also adding Appium Headspin giving error

image (16)

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , api response for above error Tag id 602 is not valid

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Dec 22, 2020
@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Thanks.

This an API issue:

image

@Dara-K
Copy link

Dara-K commented Dec 22, 2020

Hey guys,

The Appium icon is smaller in the design than in the development. If you look carefully, there is some distance from the logo/icon to the border of the gray square. Can we fix this please? Same for Headspin (should be a bit smaller to have consistent padding as the other icons we already have)
image

@luizrrodrigues
Copy link
Collaborator

Hey @Dara-K,

To follow the existing way to add icons to Skills, we need to apply padding directly in SVG icon.

Please ref. existing icons here:
https://github.com/topcoder-platform/community-app/tree/develop/src/assets/images/profile/skills

@Dara-K
Copy link

Dara-K commented Dec 23, 2020

Noted on that and updated the icons here. Thanks!
Appium and Headspin Icons Profile.zip

@luizrrodrigues
Copy link
Collaborator

@Dara-K Thanks. Deployed in Stag env: https://staging-community-app.topcoder.com/settings/profile#skills

@SathyaJayabal ready for QA.

@luizrrodrigues luizrrodrigues added Ready for QA and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Dec 23, 2020
@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues , verified
Screenshot 2020-12-24 at 9 34 05 AM

@SathyaJayabal
Copy link
Collaborator

@Oanh-and-only-Oanh @luizrrodrigues , I ran a test challenge with the Appium and Appium Headspin skills but the
skills were not added to the winner's profile.
Challenge
https://www.topcoder.com/challenges/9a65a3b4-b69d-4ead-b005-6a037c0fdc9c
Winner
https://www.topcoder.com/members/CustomerUser
Screenshot 2020-12-24 at 11 44 48 AM
Screenshot 2020-12-24 at 11 44 54 AM

@Oanh-and-only-Oanh
Copy link
Author

@luizrrodrigues, is the skill added to member API but frontend is not showing it?

@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh @SathyaJayabal sorry these comments.

@SathyaJayabal you mean about not auto added verification mark?

@SathyaJayabal
Copy link
Collaborator

@SathyaJayabal you mean about not auto added verification mark?

yes, the skill must be auto added to the member's profile with verification mark

@luizrrodrigues
Copy link
Collaborator

I think skill not auto added, just verification mark will be added to winner. But no sure, this was working before with other skills?

@SathyaJayabal
Copy link
Collaborator

verified , icons added fore Appium and Appium Headspin
Screenshot 2020-12-29 at 5 28 20 PM
Screenshot 2020-12-29 at 5 28 25 PM

@SathyaJayabal
Copy link
Collaborator

verified on prod, icons added for Appium and Appium Headspin
Screenshot 2020-12-30 at 6 48 16 AM
Screenshot 2020-12-30 at 6 48 23 AM

@luizrrodrigues
Copy link
Collaborator

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30159644

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Member Profiles P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Development

No branches or pull requests

5 participants