Update "Join Community" link in footer

[SathyaJayabal]

Join community link in the footer must point to new auth0 registration page

cc @sachin-maheshwari

[sachin-maheshwari]

@luizrrodrigues please fix on priority. We are targeting prod release by next week (20 Oct 2020).

[sandhiyakavi]

@luizrrodrigues @sachin-maheshwari If user is logged in and click Join Community, 404 HTTP Error is displayed.(redirected to url https://www.topcoder-dev.com/challenges&utm_source=community)

Joincommunity_404_error.zip

[luizrrodrigues]

@sandhiyakavi I can't reproduce this issue, can you try clear cookies?

2020-10-14 11-16-42.zip

[luizrrodrigues]

cc @SathyaJayabal

[luizrrodrigues]

@SathyaJayabal @sandhiyakavi I'm able to reproduce now.

@sachin-maheshwari This issue coming from: https://github.com/topcoder-platform/tc-auth-lib/blob/b45d1fa474f3df217d1808c798fd771fc3405868/web-assets/js/setupAuth0WithRedirect.js#L46

let returnAppUrl = qs['retUrl'];
...
...
returnAppUrl += '&utm_source=' + utmSource;
...
...
if (isAuthenticated) {
    window.location = returnAppUrl;
} 

Missing ? between URL and params, I think can fix this with:

const returnAppUrl = new URL(qa['retUrl']);
...
...
returnAppUrl.searchParams.append('utm_source', utmSource);
...
...
if (isAuthenticated) {
    window.location = returnAppUrl.href;
} 

[sachin-maheshwari]

@LieutenantRoger good catch 👍

[sachin-maheshwari]

@sushilshinde just curious, what is use of passing parameters (utm_source=community&utm_campaign=tc-footer&utm_medium=promotion) -https://accounts-auth0.topcoder-dev.com/?utm_source=community&utm_campaign=tc-footer&utm_medium=promotion&retUrl=https%3A%2F%2Fwww.topcoder-dev.com%2Fchallenges
Still we are using for any tracking ? can we remove utm_source ?

[sachin-maheshwari]

fixed. I restricted domain change in "auth lib" for our enterprise customer only i.e. wipro, zurich and cs.

[SathyaJayabal]

@luizrrodrigues

1. Not logged in user: When clicking on Join community, the signup tab must be selected by default. (In production, Join community takes the user to the Join topcoder registration page)

2. Logged in user : When a logged in user clicks on "Join community" , the page is redirected to the same page, without opening the signup page (In production, even when the user is logged in Join Topcoder registration page is displayed).
   5101.mov.zip

@Oanh-and-only-Oanh , what should be the expected behaviour here ?

[Oanh-and-only-Oanh]

@SathyaJayabal,

1. correct on this behavior
2. If the user is logged in, the "join community" link in the footer should not be visible.

[SathyaJayabal]

@luizrrodrigues , can you make the change for the below pls?

@SathyaJayabal,

1. correct on this behavior
2. If the user is logged in, the "join community" link in the footer should not be visible.

[luizrrodrigues]

1. I think currently auth lib not support that, @sachin-maheshwari can we add this feature? Maybe if provide regSource show SignUp by default?

2. Fixed.

[sachin-maheshwari]

@mtwomey Need your input here. As we discussed, i think, current scenario is fine.

[SathyaJayabal]

verified 1.

[mtwomey]

@sachin-maheshwari We might be able to fix, but let's keep this low priority, we can review it after the release.

The idea is that if the use is not logged in and they click join community, the auth window should open, but it starts on the register tab, that's the thought - correct?