Skip to content

[$25] Footer: Track nav item in nav must be highlighted when track pages are accessed from the footer #5035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Oct 1, 2020 · 9 comments
Closed

[$25] Footer: Track nav item in nav must be highlighted when track pages are accessed from the footer #5035

SathyaJayabal opened this issue Oct 1, 2020 · 9 comments
Assignees
@PrakashDurlabhji
Labels
Bug Bash Issues going in next bug bash P4 Low (resolve within 2 weeks) Prod Env Environment tcx_Assigned tcx_FixAccepted tcx_Paid
Milestone
v1.5.1

Comments

@SathyaJayabal
Copy link
Collaborator

Footer: Track nav items in nav must be highlighted when the below track pages are accessed from the footer :
Data Science
Design
Development
QA
actual: Thrive nav item is highlighted when the track pages(Data Science, Design, Development and QA) are accessed from the footer.
expected: Track pages in nav must be highlighted (like how it is for COMPETITIVE PROGRAMMING )
footer_tracks.mov.zip
@SathyaJayabal SathyaJayabal added the P4 Low (resolve within 2 weeks) label Oct 1, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added the Bug Bash Issues going in next bug bash label Oct 10, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Footer: Track nav item in nav must be highlighted when track pages are accessed from the footer [$25] Footer: Track nav item in nav must be highlighted when track pages are accessed from the footer Oct 10, 2020
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30145879 has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@luizrrodrigues done in PR #5115

@luizrrodrigues luizrrodrigues mentioned this issue Oct 15, 2020
Merged
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30145879 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for luizrrodrigues via Topcoder X

@SathyaJayabal
Copy link
Collaborator Author

verified
thrive footer links.mov.zip

@luizrrodrigues
Copy link
Collaborator

Closing to release payment and reopen to wait for release

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30145879

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues luizrrodrigues added this to the Release by 11/3/2020 milestone Nov 2, 2020
@luizrrodrigues luizrrodrigues mentioned this issue Nov 3, 2020
Merged
@sandhiyakavi
Copy link
Collaborator

Verified on staging.
issue_5035_Pass.zip

@SathyaJayabal
Copy link
Collaborator Author

verified on prod

@SathyaJayabal
Copy link
Collaborator Author

https://drive.google.com/file/d/1iXqXA0YQfRP_toBils0wC9Ux4kh2iiC3/view?usp=sharing

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed QA Pass in Staging labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrakashDurlabhji PrakashDurlabhji

Labels
Bug Bash Issues going in next bug bash P4 Low (resolve within 2 weeks) Prod Env Environment tcx_Assigned tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
v1.5.1
Development

No branches or pull requests
5 participants
@luizrrodrigues @PrakashDurlabhji @Oanh-and-only-Oanh @sandhiyakavi @SathyaJayabal