Skip to content

[$60] Search needs to include searching in tags #5026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Oct 1, 2020 · 16 comments
Closed

[$60] Search needs to include searching in tags #5026

SathyaJayabal opened this issue Oct 1, 2020 · 16 comments
Assignees
Milestone

Comments

@SathyaJayabal
Copy link
Collaborator

In the current implementation, the search returns text matches in the tech tags too.
example:
Screenshot 2020-10-01 at 10 21 05 AM
This is not the case for the new listing implementation. The search only includes the challenge title.

cc @Oanh-and-only-Oanh

@SathyaJayabal SathyaJayabal added P3 Normal (resolved within 7 days) listing:re-implementation labels Oct 1, 2020
@SathyaJayabal SathyaJayabal changed the title Search does not include seraching in tags Search does not include searching in tags Oct 1, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Search does not include searching in tags [$60] Search does not include searching in tags Oct 1, 2020
@luizrrodrigues
Copy link
Collaborator

@Oanh-and-only-Oanh @SathyaJayabal

I think Search Challenge input needs to search just for challenge name filed, check placeholder:

image

@SathyaJayabal
Copy link
Collaborator Author

@Oanh-and-only-Oanh , I agree with @luizrrodrigues . Even though current implementation includes tags, we could go with just search in the challenge name. Since we already have a filter by tags feature.

@LieutenantRoger
Copy link
Collaborator

I thought the same in first place. But including the challenges with matched tags could be better.

@Oanh-and-only-Oanh
Copy link

The experience of being able to use the challenge search for tags in helpful.

@luizrrodrigues
Copy link
Collaborator

challenge-api feature request: topcoder-platform/challenge-api#316

@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title [$60] Search does not include searching in tags [$60] Search needs to include searching in tags Oct 2, 2020
@rootelement
Copy link
Contributor

The API fix is deployed in prod. Please change API queries where you're searching:
from: ?name=<search input>
to: ?search=<search input>

That will search across title, tags, and description.

@rootelement
Copy link
Contributor

@sushilshinde ^

@Oanh-and-only-Oanh
Copy link

@luizrrodrigues ^

@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30155542 has been created for this ticket.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues luizrrodrigues self-assigned this Dec 2, 2020
@luizrrodrigues
Copy link
Collaborator

Contest https://www.topcoder.com/challenges/30155542 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for luizrrodrigues via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Deployed in Stag env

@luizrrodrigues luizrrodrigues added this to the v1.6.3 milestone Dec 2, 2020
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , verified
Screenshot 2020-12-03 at 5 20 55 PM

@SathyaJayabal
Copy link
Collaborator Author

verified on staging (develop branch)
Screenshot 2020-12-04 at 10 06 08 AM

@SathyaJayabal
Copy link
Collaborator Author

Note: Search also includes contest spec content.

@SathyaJayabal SathyaJayabal added QA Pass in PROD Passed verification on Production and removed QA Pass in Staging labels Dec 4, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-12-04 at 1 11 41 PM

@luizrrodrigues
Copy link
Collaborator

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30155542

This is an automated message for luizrrodrigues via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants