Skip to content

[$50]Submission uploaded from support #4667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jul 21, 2020 · 13 comments
Closed

[$50]Submission uploaded from support #4667

SathyaJayabal opened this issue Jul 21, 2020 · 13 comments

Comments

@SathyaJayabal
Copy link
Collaborator

I had support register and submit for a challenge to see how it works with the V5 api on the FE.

Registration works as expected. But for submission, the member handle is replaced with the support staff name.

example challenge:
https://www.topcoder.com/challenges/30131098?tab=submissions
https://beta-community-app.topcoder.com/challenges/0ea10b6f-c089-457b-8c08-b01be006b25e?tab=submissions

Screenshot 2020-07-21 at 9 07 29 PM

cc @lakshmiathreya @sushilshinde @callmekatootie @rootelement

@callmekatootie
Copy link
Collaborator

If it helps with the debugging - submission api uses the memberId that is passed to it. So you would need to look at the source of the memberId in this case...

@SathyaJayabal
Copy link
Collaborator Author

@rootelement , support uses the submission api to upload the submission, using their JWT token.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 22, 2020

This is the submission object returned by the submissions api, that was uploaded by support. I think the V5 FE must use the memberId to display the user handle and not the updatedBy or createdBy fields. cc @sushilshinde @rootelement

"updatedBy": "ritesh_cs",
        "created": "2020-07-21T14:23:22.135Z",
        "legacySubmissionId": 386204,
        "isFileSubmission": true,
        "type": "Contest Submission",
        "url": "https://s3.amazonaws.com/topcoder-submissions/0e6eed27-257f-4f2e-8425-323cfdb317c8.zip",
        "challengeId": 30131098,
        "filename": "Test Sub - Ritesh Gupta.zip",
        "createdBy": "ritesh_cs",
        "review": [
            {
                "score": 100,
                "updatedBy": "mL4037GVeLQOvb8TgU4KW38mlevpfp4y@clients",
                "reviewerId": "1b1ac501-1550-410f-ad49-e99948e68c42",
                "submissionId": "0e6eed27-257f-4f2e-8425-323cfdb317c8",
                "createdBy": "mL4037GVeLQOvb8TgU4KW38mlevpfp4y@clients",
                "created": "2020-07-21T14:23:25.523Z",
                "scoreCardId": 30001850,
                "typeId": "55bbb17d-aac2-45a6-89c3-a8d102863d05",
                "id": "5fd7d59c-8ea6-4235-a410-213e082761a9",
                "updated": "2020-07-21T14:23:25.523Z",
                "status": "completed"
            }
        ],
        "id": "0e6eed27-257f-4f2e-8425-323cfdb317c8",
        "submissionPhaseId": 1359386,
        "updated": "2020-07-21T14:23:22.135Z",
        "fileType": "zip",
        "memberId": 22778049
    },

@Oanh-and-only-Oanh Oanh-and-only-Oanh added P3 Normal (resolved within 7 days) and removed P2 Important (resolve within 3 days) labels Aug 11, 2020
@SathyaJayabal SathyaJayabal added this to the V5 Challenge API v1.4 milestone Aug 13, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added the P2 Important (resolve within 3 days) label Aug 17, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the P3 Normal (resolved within 7 days) label Aug 17, 2020
@sushilshinde sushilshinde changed the title Submission uploaded from support [$50]Submission uploaded from support Aug 17, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30137541 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30137541 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal @sushilshinde @rootelement

If we use memberIdto show user handle we'll need make one call to each member, I think this not good.

@rootelement Is possible we receive memberHandle in this call?

@luizrrodrigues
Copy link
Collaborator

@sushilshinde PR is ready ☝️

@sushilshinde
Copy link
Collaborator

Thanks, some technicical problem with the staging environemnts PR so not merged.

@luizrrodrigues
Copy link
Collaborator

@sushilshinde Need anything from my side here?

@sushilshinde
Copy link
Collaborator

No

@lakshmiathreya
Copy link

Submission uploaded by Support shows member handle correctly:
Screenshot 2020-08-21 at 9 49 02 AM
Screenshot 2020-08-21 at 9 48 26 AM

@lakshmiathreya
Copy link

Screenshot 2020-08-25 at 8 15 45 AM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30137541

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants