Skip to content

[$40]Challenge Details: Source file formats section is missing #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Jun 7, 2020 · 21 comments
Closed

[$40]Challenge Details: Source file formats section is missing #4482

SathyaJayabal opened this issue Jun 7, 2020 · 21 comments
Assignees
@rashmi73
Labels
Beta Env Environment CF Retested Challenge Details Screen Merged for QA P2 Important (resolve within 3 days) QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid tcx_ReadyForReview v5-intgration-sub-code

Comments

@SathyaJayabal
Copy link
Collaborator

V5 URL:https://beta-community-app.topcoder.com/challenges/5776a168-9c4a-43ea-9a69-a5f369777b3a
V4 URL:https://www.topcoder.com/challenges/30127937
Challenge Details: Source file formats section is missing
Screenshot 2020-06-07 at 12 21 24 PM
Screenshot 2020-06-07 at 12 22 03 PM
@sushilshinde sushilshinde changed the title Challenge Details: Source file formats section is missing [$40]Challenge Details: Source file formats section is missing Jun 7, 2020
@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

@crazyk07
Copy link

crazyk07 commented Jun 7, 2020

Contest https://www.topcoder.com/challenges/30128606 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@rashmi73 rashmi73 self-assigned this Jun 7, 2020
@crazyk07
Copy link

crazyk07 commented Jun 7, 2020

Contest https://www.topcoder.com/challenges/30128606 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 7, 2020

@sushilshinde @rootelement here is PR #4487

also make sure metadata array has object present with name "fileTypes" in v5 api, because currently it is not present in v5 response and also once available in v5 it wont be visible unless my PR is merged because "type" is renamed to "name" in metadata.

@srjr19
Copy link
Contributor

srjr19 commented Jun 7, 2020

@sushilshinde @rootelement here is PR #4487

also make sure metadata array has object present with name "fileTypes" in v5 api, because currently it is not present in v5 response and also once available in v5 it wont be visible unless my PR is merged because "type" is renamed to "name" in metadata.

@rashmi73 test with http://api.topcoder-dev.com/v5/challenges?legacyId=30048648

@SathyaJayabal FYI too for testing ☝️

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Jun 8, 2020
@SathyaJayabal
Copy link
Collaborator Author

@rashmi73 @sushilshinde ,we are getting a blank page on loading challenge details page for design contests, with error related to file types. Please see screenshot.

The api does return the "fileTypes" in the meta data array.
http://api.topcoder-dev.com/v5/challenges?legacyId=30048648
http://api.topcoder.com/v5/challenges?legacyId=30127937
Screenshot 2020-06-08 at 10 15 10 AM

@SathyaJayabal SathyaJayabal added P0 Critical (resolve within 4 hours) and removed P2 Important (resolve within 3 days) labels Jun 8, 2020
@sushilshinde
Copy link
Collaborator

@rashmi73 please patch

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 8, 2020

@sushilshinde patching

@sushilshinde
Copy link
Collaborator

Reverting code.

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 8, 2020

@sushilshinde that failure is due to my code?

@sushilshinde
Copy link
Collaborator

Yes

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jun 8, 2020 •
edited
Loading

@rashmi73 are you sending PR? please do that in 4 hours

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 8, 2020

@sushilshinde it is completed I just forgot to mention it here PR #4489

@sushilshinde sushilshinde added Ready for QA and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jun 8, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on test and beta
Screenshot 2020-06-08 at 1 59 18 PM
Screenshot 2020-06-08 at 2 00 56 PM

@SathyaJayabal SathyaJayabal added P2 Important (resolve within 3 days) and removed P0 Critical (resolve within 4 hours) labels Jun 9, 2020
@crazyk07
Copy link

crazyk07 commented Jun 9, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30128606

This is an automated message for crazyk via Topcoder X

@sushilshinde sushilshinde reopened this Jun 9, 2020
@sushilshinde
Copy link
Collaborator

@rashmi73 please PR this again, I had to revert for other reason.

nothing to do with you code.

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 9, 2020

@sushilshinde sure

@rashmi73
Copy link
Contributor

rashmi73 commented Jun 9, 2020

@sushilshinde here is PR again #4508

@Oanh-and-only-Oanh
Copy link

@SathyaJayabal @lakshmiathreya, can you close this one yet?

@SathyaJayabal
Copy link
Collaborator Author

@SathyaJayabal @lakshmiathreya, can you close this one yet?

@Oanh-and-only-Oanh , this was also reverted with the rest on tuesday. New PR is merged now- We will test and close it.

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 11, 2020 •
edited
Loading

verified on beta env

Screenshot 2020-06-11 at 8 59 57 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rashmi73 rashmi73

Labels
Beta Env Environment CF Retested Challenge Details Screen Merged for QA P2 Important (resolve within 3 days) QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid tcx_ReadyForReview v5-intgration-sub-code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sushilshinde @srjr19 @rashmi73 @crazyk07 @Oanh-and-only-Oanh @SathyaJayabal