Skip to content

[$50]Challenge Details: Checkpoint prize details missing for design contests #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 1, 2020 · 26 comments

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jun 1, 2020

Checkpoint prize details missing for design contests
user: not logged in
V4 URL:https://www.topcoder.com/challenges/30126014
V5 URL:https://beta-community-app.topcoder.com/challenges/fbd47239-43dc-4f50-8d0d-739dfe82191a
Screenshot 2020-06-01 at 10 34 21 AM

@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde sushilshinde changed the title Challenge Details: Checkpoint prize details missing for design contests [$50]Challenge Details: Checkpoint prize details missing for design contests Jun 2, 2020
@crazyk07
Copy link

crazyk07 commented Jun 2, 2020

Contest https://www.topcoder.com/challenges/30127613 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

To fix this issue
Use details API call -
http://api.topcoder-dev.com/v5/challenges/741f427e-9f4c-4735-9448-45afaf21455e

(call with legacy challenge id for ref, don't use it http://api.topcoder-dev.com/v5/challenges?legacyId=30047827)

Context:

The only data point that changed from how it was previously is prizeSets. To accommodate the checkpoint prizes, I cleaned up the object a little bit. You’ll notice in this object:
http://api.topcoder-dev.com/v5/challenges?legacyId=30047827
Prize Sets now looks like this:
"prizeSets": [
{
"type": "placement",
"description": "Challenge Prizes",
"prizes": [
{
"value": 1500,
"type": "USD"
},
{
"value": 500,
"type": "USD"
}
]
},
{
"type": "checkpoint",
"description": "Checkpoint Prizes",
"prizes": [
{
"value": 100,
"type": "USD"
},
{
"value": 100,
"type": "USD"
},
{
"value": 100,
"type": "USD"
},
{
"value": 100,
"type": "USD"
},
{
"value": 100,
"type": "USD"
}
]
}
],
The change is that before this migration, the “type” for the Challenge Prizes was Challenge Prizes. I’ve changed that type to be placement. That allows for the addition of checkpoint type which is more logical.

@sushilshinde
Copy link
Collaborator

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

@crazyk07
Copy link

crazyk07 commented Jun 2, 2020

Contest https://www.topcoder.com/challenges/30127613 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

@narekcat
Copy link
Contributor

narekcat commented Jun 2, 2020

@SathyaJayabal @sushilshinde Something wrong with beck end. I can't reproduce the issue.
image
image

@rootelement
Copy link
Contributor

Challenges were re-migrated. They all got new UUIDs. You can use this one:
http://api.topcoder-dev.com/v5/challenges?legacyId=30048648
http://api.topcoder-dev.com/v5/challenges/8e48e825-1f82-48d6-9c99-de2671fd3302

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@rootelement Ok. Thanks.

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@SathyaJayabal @sushilshinde The checkpoint prizes can have different values. Need I display each of them, like challenge prizes ? What about reliability bonus ? I have checked challenge-api repository and there are nothing about reliability bonus.

@sushilshinde
Copy link
Collaborator

@Oanh-and-only-Oanh @SathyaJayabal please help

@SathyaJayabal
Copy link
Collaborator Author

@narekcat , as far as I know checkpoint prizes have the same values, example either 5 prizes of $100, or 10 prizes of $50 etc. If you did see an example where there were different amounts for checkpoint prizes, please share the link.

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@SathyaJayabal Ok. Does prizeSets include reliability bonus ?

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 3, 2020

@Oanh-and-only-Oanh can you help with reliability bonus? Do we still offer reliability bonus? @narekcat , do you have any example of an existing challenge with reliability bonus.

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@SathyaJayabal No I haven't. I have check all active challenges, but there is no reliability bonus. Actually I can remove code associated with reliability bonus. I need to check before changing code.

@SathyaJayabal
Copy link
Collaborator Author

@narekcat , lets wait for @Oanh-and-only-Oanh 's reply regarding reliability bonus.

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@SathyaJayabal Ok.

@Oanh-and-only-Oanh
Copy link

Can we keep reliability bonus as an option feature that copilots can decided to add or remove?

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@Oanh-and-only-Oanh If you asking my opinion, then we can.

@Oanh-and-only-Oanh
Copy link

I meant, don't remove code associated with reliability bonus. keep it as option.

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@Oanh-and-only-Oanh Ok. I understand.

@sushilshinde
Copy link
Collaborator

@narekcat please PR in 12 hours

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@sushilshinde I'll finish this issue in an hours.

@narekcat
Copy link
Contributor

narekcat commented Jun 3, 2020

@sushilshinde I have fixed this issue. Please see pull request #4462.

@SathyaJayabal
Copy link
Collaborator Author

Verified on beta and test. Checkpoint prizes displayed as expected.
Screenshot 2020-06-04 at 1 40 43 PM
Screenshot 2020-06-04 at 1 41 11 PM

@crazyk07
Copy link

crazyk07 commented Jun 6, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30127613

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants