-
Notifications
You must be signed in to change notification settings - Fork 212
[$60]Fix content at the bottom of Challenge Details pages #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@topcoder-platform/tcxcommunity @topcoder-platform/topcodercompetitors |
Contest https://www.topcoder.com/challenges/30122231 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30122231 has been updated - it has been assigned to rashmi73. |
@hokienick @sushilshinde @Oanh-and-only-Oanh some clarification needed.
|
As an overall note, any link that links to the help center or a help center article should be updated to the proper area in Thrive. @Oanh-and-only-Oanh please speak with Tony or someone similar to get proper verbiage to use for this bottom content. |
@skyhit, let's just update the links for now. Links should be the following. Development Reliability Ratings and Bonuses: https://www.topcoder.com/thrive/articles/Development%20Reliability%20Ratings%20and%20Bonuses |
@rashmi73 please revise your change according to the requirement above. |
@skyhit updating in few minutes |
@rashmi73 test failed, please fix. |
@rashmi73 some test failed, after I merged your changes to branch, please help fix it - https://circleci.com/gh/topcoder-platform/community-app/8398 |
@skyhit checking |
@rashmi73 any update? |
@skyhit ohh sorry typed comment but forgot to press comment button, my comment was that it is not related to my change mostly, as my PR was perfect which had passed linting. but source branch itself had issues which got error after merging. |
@rashmi73 I am not sure for this. check this develop...hot-fix-content-at-bottom-of-challenge-details |
@skyhit yes found it what is the issue going to above link pasted by you.
|
@rashmi73 is probably diff problem, because you can see it here - https://github.com/rashmi73/community-app/blob/0b9e4468f77fa7840eefcad4593bba4d4662b916/__tests__/shared/components/__snapshots__/TopcoderFooter.jsx.snap#L8-L54 |
@rashmi73 I think I fixed it:) |
@skyhit yes that code was newly added, and even circleci said remove that to fix it |
verified in Test Environment.Working as expected. |
Tested in Beta Env. working as expected. |
Tested and verified in Production Environment. |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30122231 |
Uh oh!
There was an error while loading. Please reload this page.
I realized when working on creating a challenge with Kiril that the links at the bottom of the challenge details page that come with every challenge are pointing to the help center, which we are no longer using
Example challenge: https://www.topcoder.com/challenges/30122094
The content should be reviewed, and if we are going to use the same links, please have them link the the Thrive article instead of the Help Center.
Payment Policies and Instructions: https://www.topcoder.com/thrive/articles/Payment%20Policies%20and%20Instructions
Development Reliability Ratings and Bonuses: https://www.topcoder.com/thrive/articles/Development%20Reliability%20Ratings%20and%20Bonuses
About Fix
hot-fix-content-at-bottom-of-challenge-details
branchhttps://github.com/topcoder-platform/community-app/tree/hot-fix-content-at-bottom-of-challenge-details
2. all tests should be passed by
npm test
The text was updated successfully, but these errors were encountered: