Skip to content

[$60]Fix content at the bottom of Challenge Details pages #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hokienick opened this issue Apr 13, 2020 · 25 comments · Fixed by #4276
Closed

[$60]Fix content at the bottom of Challenge Details pages #4234

hokienick opened this issue Apr 13, 2020 · 25 comments · Fixed by #4276

Comments

@hokienick
Copy link

hokienick commented Apr 13, 2020

I realized when working on creating a challenge with Kiril that the links at the bottom of the challenge details page that come with every challenge are pointing to the help center, which we are no longer using

Example challenge: https://www.topcoder.com/challenges/30122094

The content should be reviewed, and if we are going to use the same links, please have them link the the Thrive article instead of the Help Center.

Payment Policies and Instructions: https://www.topcoder.com/thrive/articles/Payment%20Policies%20and%20Instructions

Development Reliability Ratings and Bonuses: https://www.topcoder.com/thrive/articles/Development%20Reliability%20Ratings%20and%20Bonuses

About Fix

  1. Please fix and PR to hot-fix-content-at-bottom-of-challenge-details branch

https://github.com/topcoder-platform/community-app/tree/hot-fix-content-at-bottom-of-challenge-details
2. all tests should be passed by npm test

@skyhit skyhit changed the title Fix content at the bottom of Challenge Details pages [$60]Fix content at the bottom of Challenge Details pages Apr 14, 2020
@skyhit
Copy link
Contributor

skyhit commented Apr 14, 2020

@topcoder-platform/tcxcommunity @topcoder-platform/topcodercompetitors

@rashmi73 rashmi73 self-assigned this Apr 14, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30122231 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30122231 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

@skyhit HELP center alreaady using thrive url so did not replace it, and also I have added two new fields, RATINGS & BONUSES and PAYMENT POLICY in bottom part of challenge.

I hope this is expectation, kindly verify

#4250

@skyhit
Copy link
Contributor

skyhit commented Apr 15, 2020

@hokienick @sushilshinde @Oanh-and-only-Oanh some clarification needed.

  1. the change is specific to challenge detail page?
  2. should we remove the Help Center link? or we should display them somewhere else in the challenge detail page?

@hokienick
Copy link
Author

@skyhit

  1. Yes, this is specific to the challenge details page. I only explored a development challenge, but there could be other types of challenges with different static content at the bottom. My ask was just to change the urls to those links as specified.

  2. All links to the "Help Center" should be re-linked to: https://www.topcoder.com/thrive/tracks?track=Topcoder&tax=Help%20Articles

As an overall note, any link that links to the help center or a help center article should be updated to the proper area in Thrive.

@Oanh-and-only-Oanh please speak with Tony or someone similar to get proper verbiage to use for this bottom content.

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Apr 15, 2020

@skyhit, let's just update the links for now.

image

Links should be the following.
Payment Policies and Instructions: https://www.topcoder.com/thrive/articles/Payment%20Policies%20and%20Instructions

Development Reliability Ratings and Bonuses: https://www.topcoder.com/thrive/articles/Development%20Reliability%20Ratings%20and%20Bonuses

@skyhit
Copy link
Contributor

skyhit commented Apr 15, 2020

@rashmi73 please revise your change according to the requirement above.

@rashmi73
Copy link
Contributor

@skyhit updating in few minutes

@rashmi73
Copy link
Contributor

@skyhit new PR #4269

@skyhit
Copy link
Contributor

skyhit commented Apr 17, 2020

@rashmi73 test failed, please fix.

@rashmi73
Copy link
Contributor

@skyhit PR updated and tests passing kindly review #4269

@skyhit
Copy link
Contributor

skyhit commented Apr 18, 2020

@rashmi73 some test failed, after I merged your changes to branch, please help fix it - https://circleci.com/gh/topcoder-platform/community-app/8398

@rashmi73
Copy link
Contributor

@skyhit checking

@skyhit
Copy link
Contributor

skyhit commented Apr 20, 2020

@rashmi73 any update?

@rashmi73
Copy link
Contributor

@skyhit ohh sorry typed comment but forgot to press comment button, my comment was that it is not related to my change mostly, as my PR was perfect which had passed linting. but source branch itself had issues which got error after merging.

@skyhit
Copy link
Contributor

skyhit commented Apr 20, 2020

@rashmi73 I am not sure for this.

check this develop...hot-fix-content-at-bottom-of-challenge-details

@rashmi73
Copy link
Contributor

@skyhit yes found it what is the issue going to above link pasted by you.

  1. just visit above link.
  2. check this file tests/shared/components/snapshots/TopcoderFooter.jsx.snap
  3. in which new code is added.
  4. whereas my PR did not have that code.
  5. it is added by someone else.
  6. if we remove that green additional block then all will be fine

@skyhit
Copy link
Contributor

skyhit commented Apr 20, 2020

@skyhit
Copy link
Contributor

skyhit commented Apr 20, 2020

@rashmi73 I think I fixed it:)

@rashmi73
Copy link
Contributor

@skyhit yes that code was newly added, and even circleci said remove that to fix it

@sandhiyakavi
Copy link
Collaborator

verified in Test Environment.Working as expected.

payment_policies.zip

reliability_bonus.zip

@sandhiyakavi
Copy link
Collaborator

Tested in Beta Env. working as expected.

payment_policy.zip
reliability_bonus.zip

@sandhiyakavi sandhiyakavi added Beta Env Environment and removed Test Env Environment labels Apr 21, 2020
@SathyaJayabal SathyaJayabal added this to the v.0.30.3 milestone Apr 21, 2020
@Jobee1
Copy link
Collaborator

Jobee1 commented Apr 21, 2020

Tested and verified in Production Environment.

payment_policy.zip
realibility_bonus.zip

@Jobee1 Jobee1 added Prod Env Environment and removed Beta Env Environment Merged for smoke labels Apr 21, 2020
@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30122231

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment