Skip to content

Make the stats history data to support groupIds query params and use new API to render the stats history UI #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LieutenantRoger opened this issue Mar 26, 2020 · 18 comments
Assignees
Labels
On hold P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Milestone

Comments

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Mar 26, 2020

  1. Community-app - Allowing seeing stats history for topgear / other communities. Was disable during last release.
  1. Community-app - Change Stats History web service call to fetch data by passing groupsId, as we did for member stats, and use the retrieved stats from new API to render the UI.

Please make sure both public history page and topgear history page are working correctly.

@LieutenantRoger LieutenantRoger changed the title Make the stats history data to support groupIds query params Make the stats history data to support groupIds query params and use new API to render the stats history UI Mar 26, 2020
@LieutenantRoger LieutenantRoger self-assigned this Mar 26, 2020
@LieutenantRoger LieutenantRoger added P2 Important (resolve within 3 days) Ready for QA labels Mar 26, 2020
@LieutenantRoger
Copy link
Collaborator Author

Also please only test topgear group for now.

@LieutenantRoger
Copy link
Collaborator Author

FYI @urwithat @Oanh-and-only-Oanh

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger , was able to view both the public and private stats history page for the user standlove. There are a few inconsistencies in the data like the below

  1. Even though the ratings are different for the design, architecture and assembly tracks(for public and private history), the challenge details are all the same

Screenshot 2020-03-30 at 1 27 46 PM

  1. The rating history graph for topgear for the design track does not match the rating

Screenshot 2020-03-30 at 1 23 45 PM

3. Even though the. user has the same data. for SRMs in both the public and private history pages, the rating history graph is not displayed for topgear.

Screenshot 2020-03-30 at 1 30 37 PM

Screenshot 2020-03-30 at 1 30 43 PM

4. Rating distribution graph for private history of assembly track does not show the users rating.

Screenshot 2020-03-30 at 1 32 37 PM

@LieutenantRoger
Copy link
Collaborator Author

Hi @SathyaJayabal

As have discussed, this is the expected behavior due to the testing data preparation.

Btw, I have re-deployed the feature using topcoder-react-lib#v1000.14.0 to dev env for QA.

@LieutenantRoger LieutenantRoger added Ready for QA and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger for the. topcoder stats history page(public) there should not abe any group id passed right?

@SathyaJayabal SathyaJayabal added Need clarification Need clarification to proceed fixing the issue further and removed Ready for QA labels Mar 30, 2020
@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger for the call to stats history page for topgear, there are. two group ids passed. Topgear group is "20000000", why is the other id passed ?
Screenshot 2020-03-30 at 5 04 38 PM

@LieutenantRoger
Copy link
Collaborator Author

It's expected as well, please refer the stats call for reference when you are checking history call.

@LieutenantRoger LieutenantRoger added Ready for QA and removed Need clarification Need clarification to proceed fixing the issue further labels Mar 30, 2020
@LieutenantRoger
Copy link
Collaborator Author

@LieutenantRoger for the. topcoder stats history page(public) there should not abe any group id passed right?

Correct, when there is no group id provided in the request, the history data with groupId=10 will be returned by default.

@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger , I am. passing this one as per clarifications above. The public and topgear stats history pages are displayed for the user standlove. The group id is passed in the history call.

@SathyaJayabal
Copy link
Collaborator

verified on dev(develop branch)
Screenshot 2020-03-31 at 2 20 32 PM
Screenshot 2020-03-31 at 2 20 43 PM
Screenshot 2020-03-31 at 2 21 19 PM
Screenshot 2020-03-31 at 2 21 42 PM

@LieutenantRoger
Copy link
Collaborator Author

Thanks @SathyaJayabal

@lakshmiathreya lakshmiathreya added this to the 0.28.0 milestone Apr 1, 2020
@LieutenantRoger LieutenantRoger added Beta Env Environment and removed Dev Env labels Apr 4, 2020
@LieutenantRoger
Copy link
Collaborator Author

@lakshmiathreya please close if the ticket is resolved. It's been long time now.

@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger ,the stats data is still not visible for top gear users in production. @lakshmiathreya can u verify this please. Clicking on any user from the topgear leaderboard should show the profile page with stats.

@SathyaJayabal
Copy link
Collaborator

@LieutenantRoger the below user must have stats data in topgear but the stats are not showing up
Screenshot 2020-04-14 at 10 23 24 PM

@LieutenantRoger
Copy link
Collaborator Author

@SathyaJayabal got it. I just remembered the production data under topgear are still under processing, I think this is the reason that no data is returned, we can keep the ticket as open now, thanks.

@sushilshinde
Copy link
Collaborator

@LieutenantRoger need pr for this

@SathyaJayabal
Copy link
Collaborator

marking this as hold until backend data is ready for topgear stats history on prod
cc @LieutenantRoger @Oanh-and-only-Oanh

@LieutenantRoger LieutenantRoger added Prod Env Environment and removed Beta Env Environment labels Apr 24, 2020
@lakshmiathreya
Copy link

@Oanh-and-only-Oanh I am reopening this - it appears like Code was fixed but backend data was not available. Will leave this open until we see Stats data fully. cc @urwithat @SathyaJayabal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On hold P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Projects
None yet
Development

No branches or pull requests

4 participants