Skip to content

Migrate the Setting page into private group, e.g. topgear #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LieutenantRoger opened this issue Mar 11, 2020 · 13 comments
Closed

Migrate the Setting page into private group, e.g. topgear #4088

LieutenantRoger opened this issue Mar 11, 2020 · 13 comments
Assignees
Labels
Beta Env Environment QA Pass in PROD Passed verification on Production QA Pass
Milestone

Comments

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Mar 11, 2020

Describe the bug
Migrate the Setting page into private group: topgear

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://topgear.topcoder-dev.com/members/TonyJ
  2. Hover the user TonyJ in the top right area of the header to show a sub-header
  3. Click on 'SETTINGS' under the sub-header
  4. The site will navigate user to TonyJ public setting screen right now.

Expected behavior
We need to migrate current SETTINGS page into private domain.

So after step 3, user should be remain in the private group with Setting section displayed, and the header should be still the Private domain header.

Additional context

The work should be down against, feature-private-settings

@LieutenantRoger
Copy link
Collaborator Author

Hi @Oanh-and-only-Oanh

Here's a challenge spec for this ticket, please take a look: https://docs.google.com/document/d/1-Zwb5QGPm2ByzAb_HE9LKtiEEefPScTCJA5HGSxvID4/edit?usp=sharing

@LieutenantRoger LieutenantRoger changed the title Migrate the Profile Setting page into private group, e.g. topgear Migrate the Setting page into private group, e.g. topgear Mar 13, 2020
@Oanh-and-only-Oanh
Copy link

putting this on hold for now.

@LieutenantRoger
Copy link
Collaborator Author

LieutenantRoger commented Mar 24, 2020

@LieutenantRoger
Copy link
Collaborator Author

LieutenantRoger commented Mar 24, 2020

Hi @Oanh-and-only-Oanh

Could you tell why the deployed code in community#dev environment and my local deployed version are different for cs community ? https://take.ms/BJid1

Actually I tried otherwise private groups as well.

Right now, it seems only topgear private group are the same between deployed locally and community#dev environment. https://take.ms/xq4Ou
@SathyaJayabal has confirmed topgear private group setting page is working fine.

I suspect my changes to otherwise private groups not getting executed due to the route load balance in the community-app#dev environment.

@Oanh-and-only-Oanh
Copy link

Hi @LieutenantRoger, I'm not sure about the why there's a difference between CS dev and your local version. I can look into it. Until then, let's narrow down the scope so excludes any private community with this issue. As long as we can get this complete for Topgear...

@LieutenantRoger
Copy link
Collaborator Author

Sure

@SathyaJayabal
Copy link
Collaborator

Verified for Topgear
Screenshot 2020-03-26 at 8 53 37 AM

@LieutenantRoger
Copy link
Collaborator Author

Thanks

@lakshmiathreya
Copy link

As seen on Beta with wipro login:
Screenshot 2020-03-26 at 12 27 49 PM

@lakshmiathreya
Copy link

Settings link from the Profile redirects to Prod. Only the direct url shown above loads the Beta Settings page.

@lakshmiathreya
Copy link

All Settings sanity checked for this Profile on Beta. The changes seem to be set correctly.

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env labels Mar 26, 2020
@LieutenantRoger
Copy link
Collaborator Author

Settings link from the Profile redirects to Prod. Only the direct url shown above loads the Beta Settings page.

Hi @lakshmiathreya yes, it was due to the beta environment, when we use topgear.topcoder.com to access the topgear group, the navigation will work correctly.

@lakshmiathreya
Copy link

Verified on topgear.topcoder.com via Wipro login.

@lakshmiathreya lakshmiathreya added the QA Pass in PROD Passed verification on Production label Mar 26, 2020
@lakshmiathreya lakshmiathreya added this to the 0.26.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beta Env Environment QA Pass in PROD Passed verification on Production QA Pass
Projects
None yet
Development

No branches or pull requests

4 participants