Skip to content

New Navi integration to Contentful #4020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkartunov opened this issue Feb 20, 2020 · 8 comments
Closed

New Navi integration to Contentful #4020

kkartunov opened this issue Feb 20, 2020 · 8 comments
Assignees
Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Milestone

Comments

@kkartunov
Copy link
Collaborator

New Navi integration should remove BUSSINESS & COMMUNITY menu items to look more closely to https://marvelapp.com/5554efd/screen/65173641

Test url: https://community-app.topcoder.com/examples/contentful/viewport/1nvm6EsPMHPLBtuGXNRMYV

@kkartunov kkartunov self-assigned this Feb 20, 2020
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Feb 20, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal
Copy link
Collaborator

After clicking on a menu item, the menu gets reloaded and the does not show the correct selected menu.

https://drive.google.com/open?id=1YM1bwDIFlkQ_YIQAzklPyLe4iUvjpf4f

The new nav is https://drive.google.com/open?id=1YM1bwDIFlkQ_YIQAzklPyLe4iUvjpf4f
Screenshot 2020-02-25 at 10 56 21 PM
different from the one in the design. Do you have an updated design
Screenshot 2020-02-25 at 10 56 07 PM

@SathyaJayabal SathyaJayabal added Beta Env Environment QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 25, 2020
@kkartunov
Copy link
Collaborator Author

@SathyaJayabal this is all fine and controllable from Contentful. You should just confirm that it looks like in the design. In prod, links will not reload and will have different organizations.

So please update this one. Thanks!

@hokienick
Copy link

@SathyaJayabal - As @kkartunov mentioned, he has just updated the functionality and design of this navigation bar to align with our marketing navigation.

In this environment the navigation will not direct you to the appropriate page because it is just an example viewport with the menu overlayed on top so that we can see that the animations and the format are to our liking.

The reason the navigation reloads each time is because the link changes every time because it is faked with a prefix. Once this is in production, it will not have these issues. We do need this in the next release please.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 26, 2020
@SathyaJayabal
Copy link
Collaborator

@hokienick , I am marking this as pass based on above comments.

@SathyaJayabal
Copy link
Collaborator

verified on beta (develop branch)
Screenshot 2020-02-26 at 2 43 26 PM

@SathyaJayabal SathyaJayabal added this to the v0.20.03 milestone Feb 26, 2020
@SathyaJayabal
Copy link
Collaborator

verified on beta
Screenshot 2020-02-28 at 10 57 39 AM

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Feb 28, 2020
@SathyaJayabal
Copy link
Collaborator

verified in prod
Screenshot 2020-02-28 at 3 48 01 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contentful-DEV Internal development operations for Contentful Prod Env Environment QA Pass
Projects
None yet
Development

No branches or pull requests

3 participants