Skip to content

[$35]Challenge Listings - Search : Must have a X button to clear search #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Jan 30, 2020 · 16 comments · Fixed by #4274
Closed

[$35]Challenge Listings - Search : Must have a X button to clear search #3622

SathyaJayabal opened this issue Jan 30, 2020 · 16 comments · Fixed by #4274
Assignees
@narekcat
Labels
Challenge Listing Code Review Passed P4 Low (resolve within 2 weeks) Prod Env Environment QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid UX Issues related to User Experience
Milestone
v0.30.4

Comments

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Jan 30, 2020 •
edited by skyhit
Loading

Describe the bug
The challenge search input must have a X button to clear the search

To Reproduce
Steps to reproduce the behavior:

  1. go to challenge listing page
  2. type any keyword in the search box and click on search button
  3. challenge list is updated to show search results

Actual: There is no x button to clear the search. The user either has to delete the search keyword and search again or use clear filter button to clear the search

Expected: There should be a X button to clear the search.

Please make PR against https://github.com/topcoder-platform/community-app/tree/hot-fix-x-button-to-clear-search
@SathyaJayabal SathyaJayabal added Challenge Listing P4 Low (resolve within 2 weeks) UX Issues related to User Experience labels Jan 30, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh removed their assignment Jan 30, 2020
@skyhit skyhit changed the title Challenge Listings - Search : Must have a X button to clear search [$35]Challenge Listings - Search : Must have a X button to clear search Apr 15, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30122325 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@narekcat narekcat self-assigned this Apr 15, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30122325 has been updated - it has been assigned to Narekvar90.

This is an automated message for crazyk via Topcoder X

@narekcat narekcat mentioned this issue Apr 15, 2020
Merged
@narekcat
Copy link
Contributor

I added X button to clear the search. This is the PR for this issue: #4255. The CircleCI test's fails, because of automatically generated class names. Is it normal ? How can it be fixed ?

@skyhit
Copy link
Contributor

skyhit commented Apr 16, 2020

@narekcat the functionality seems working (https://monosnap.com/file/h5WGTTOl4uSF5apMZw1pyzMqZU9Yj6), but the tests failed, please check why.

@narekcat
Copy link
Contributor

@skyhit Ok, working on it.

@narekcat
Copy link
Contributor

@skyhit I fixed tests issues.

@sandhiyakavi
Copy link
Collaborator

sandhiyakavi commented Apr 17, 2020 •
edited
Loading

If the text content is more, the 'x' button is overlapping with the text.

x button

cc: @skyhit

@sandhiyakavi sandhiyakavi added QA Fail QA verification on Dev has failed. Assignee to redo the fix. Test Env Environment labels Apr 17, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh added QA Pass and removed tcx_FixAccepted QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Apr 17, 2020
@Oanh-and-only-Oanh
Copy link

@skyhit, verified in test environment.

@skyhit skyhit mentioned this issue Apr 21, 2020
Merged
@crazyk07
Copy link

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for crazyk via Topcoder X

@sushilshinde sushilshinde reopened this Apr 21, 2020
@sandhiyakavi
Copy link
Collaborator

Tested in Beta Env.Working as expected.

search_textbox_clear_button.zip

@sandhiyakavi sandhiyakavi added Beta Env Environment and removed Test Env Environment labels Apr 21, 2020
@SathyaJayabal SathyaJayabal added this to the v.0.30.3 milestone Apr 21, 2020
@sushilshinde sushilshinde mentioned this issue Apr 21, 2020
Merged
@Jobee1
Copy link
Collaborator

Jobee1 commented Apr 21, 2020

Tested and verified in Production environment.

X_button_in_search.zip

@Jobee1 Jobee1 added Prod Env Environment and removed Beta Env Environment Merged for smoke labels Apr 21, 2020
@crazyk07
Copy link

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for crazyk via Topcoder X

@SathyaJayabal SathyaJayabal reopened this Apr 21, 2020
@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30122325

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@narekcat narekcat

Labels
Challenge Listing Code Review Passed P4 Low (resolve within 2 weeks) Prod Env Environment QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid UX Issues related to User Experience
Projects
None yet
Milestone
v0.30.4
Development

Successfully merging a pull request may close this issue.

Hot fix x button to clear search topcoder-platform/community-app
8 participants
@skyhit @sushilshinde @narekcat @crazyk07 @Oanh-and-only-Oanh @Jobee1 @sandhiyakavi @SathyaJayabal