Skip to content

[$30]Fix lint issue on feature-mm-submissions branch #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Jan 29, 2020 · 10 comments
Closed

[$30]Fix lint issue on feature-mm-submissions branch #3618

sushilshinde opened this issue Jan 29, 2020 · 10 comments

Comments

@sushilshinde
Copy link
Collaborator

feature-mm-submissions branch causes lint error on npm test

/Users/sushil/project/tc/community-app/src/shared/components/challenge-listing/ChallengeCard/Status/index.jsx
  335:15  error  'detailLink' PropType is defined but prop is never used               react/no-unused-prop-types
  337:28  error  'openChallengesInNewTabs' PropType is defined but prop is never used  react/no-unused-prop-types

✖ 2 problems (2 errors, 0 warnings)

PR to branch https://github.com/topcoder-platform/community-app/tree/feature-mm-submissions

@sushilshinde
Copy link
Collaborator Author

@rashmi73 please submit in 4 hours

@sushilshinde
Copy link
Collaborator Author

@veshu FYI

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30113815 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30113815 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

@sushilshinde @veshu unable to reflect locally, can you please confirm again?

@veshu
Copy link
Contributor

veshu commented Jan 29, 2020

@rashmi73 did you run npm run lint? I can reproduce locally. Also please try to remove node_modules and start fresh in this branch.

@rashmi73
Copy link
Contributor

@veshu it is done raising PR

@rashmi73
Copy link
Contributor

@veshu @sushilshinde PR #3619

@sushilshinde
Copy link
Collaborator Author

Thanks @rashmi73

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30113815

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants