Skip to content

[$20] My Submission tab: Final and Provision columns should be under the 'Score' title #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jan 20, 2020 · 14 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jan 20, 2020

Describe the bug
Final and Provision columns should be under the 'Score' title, like in the design. At present, Provision and Time columns are present under the 'Score' title.

To Reproduce
Steps to reproduce the behavior:

  1. Build the https://github.com/topcoder-platform/community-app/tree/feature-mm-submissions locally for production mode
  2. go to challenge http://localhost:3000/challenges/30094385?tab=my_submissions
  3. Check the score title is not aligned center above final and provision as shown in design https://marvelapp.com/cch42ib/screen/61330572

Expected behavior
Score should be aligned horizontally center between Final and Provision sub header.

Screenshots
https://user-images.githubusercontent.com/5114190/72375646-763fb300-3732-11ea-952c-5ec7e431d347.png

Branch to use

feature-mm-submissions

** Submission **
Submit PR against above branch. make sure lint and tests are passing.

@veshu
Copy link
Contributor Author

veshu commented Jan 20, 2020

@topcoder-platform/topcodercompetitors this is open for pickup.

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30113144 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30113144 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

@PrakashDurlabhji
Copy link
Contributor

@veshu unable to run locally, on feature-mm-submissions branch.
challenge page comes blnak and error in browser console.

  1. steps taken, npm install, npm run dev.

everytime it worked but this time error.

@PrakashDurlabhji
Copy link
Contributor

@veshu also unable to see my submission tab at http://beta-community-app.topcoder.com/challenges/30094385
even though I submitted succesfuly to it

@veshu
Copy link
Contributor Author

veshu commented Jan 21, 2020

@PrakashDurlabhji Please check on production mode.

npm run build
npm start

After this it will load the home page from there click production challenge link. Which will let you go to the challenge detail, go the challenge mode then you will see above challenge. select that challenge and submit you should see the my submissions.

Don't go by pasting full url on navigation bar.

@veshu
Copy link
Contributor Author

veshu commented Jan 22, 2020

@topcoder-platform/topcodercompetitors this is open for pickup.

@PrakashDurlabhji PrakashDurlabhji self-assigned this Jan 22, 2020
@PrakashDurlabhji
Copy link
Contributor

@veshu sorry for delay completing immediately

@veshu
Copy link
Contributor Author

veshu commented Jan 22, 2020

@PrakashDurlabhji any update on this? if you can't submit on time then please don't hold the issue.
You are holding issues for more than 36 hours.

@PrakashDurlabhji
Copy link
Contributor

@veshu yes it is completed but commenting from mobile network as suddenly wifi is lost , pushing PR in some minutes

@veshu
Copy link
Contributor Author

veshu commented Jan 22, 2020

@PrakashDurlabhji when can we expect this?

@PrakashDurlabhji
Copy link
Contributor

@veshu apology for delay PR #3600

@PrakashDurlabhji
Copy link
Contributor

@veshu this has not been paid yet to me, can we please close this?

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30113144

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants