Skip to content

Submission Management Page for MM #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ajefts opened this issue Oct 16, 2019 · 15 comments
Closed

Submission Management Page for MM #3399

ajefts opened this issue Oct 16, 2019 · 15 comments
Assignees
@veshu
Labels
Challenge Details Screen New feature Prod Env Environment QA Pass in PROD Passed verification on Production QA Pass Submission Management Page
Milestone
v0.20.00

Comments

@ajefts
Copy link
Member

ajefts commented Oct 16, 2019 •
edited
Loading

This new feature will allow MM submitters to manage their submissions directly on the platform.

  • view submission status

  • view submission scores

  • view submission metadata

Marvel design: https://marvelapp.com/cch42ib/screen/61330572
@ajefts
Copy link
Member Author

ajefts commented Oct 16, 2019

Link to feature: https://tcprod.productboard.com/feature-board/planning/features/3112446

@lakshmiathreya
Copy link

@SathyaJayabal @nithyaasworld

@nithyaasworld
Copy link
Collaborator

@veshu Function about the new SMP is clear from the Marvel app design. I dont have access to Productboard link shared by Tony above. Is there anything else we need to know when testing?

@Oanh-and-only-Oanh
Copy link

@nithyaasworld here you go.
Building on Chris and Tony's submission mgmt page https://submission-review.topcoder.com/, how to get it in a user-ready state.
where will it live
what's the member user flow
the designs are at https://marvelapp.com/c026e87/screen/57758299 - create a list of requirements for fixing the designs

Here are the designs for the list view: https://drive.google.com/open?id=1HVryoX27HF5wk26zDERTJdGjcxoPszmN
Marvel link and Marvel handoff:
https://marvelapp.com/93iib33
Marvel Handoff:
https://marvelapp.com/93iib33/screen/58998400/handoff

@nithyaasworld
Copy link
Collaborator

@veshu
Sorting function, Upload and download submission functions are all good! Follow are the things noted but none of them are major-issue:

  1. Language column is not available, like present in the design.

  2. Final and Provision columns should be under the 'Score' title, like in the design. At present, Provision and Time columns are present under the 'Score' title.

  3. I am not able to verify the various statuses as all my submissions are stuck in 'processing'. Can you upload a valid submission and check if it shows 'success tick' status? (Or please share me a valid submission which I can upload and test)

image

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Jan 14, 2020 •
edited
Loading

@veshu @nithyaasworld, regarding above QA findings:

  1. Language column is not available, like present in the design. We don't need language anymore so this is fine.
  2. Final and Provision columns should be under the 'Score' title, like in the design. At present, Provision and Time columns are present under the 'Score' title. Yes, please fix this.
  3. I am not able to verify the various statuses as all my submissions are stuck in 'processing'. Can you upload a valid submission and check if it shows 'success tick' status? (Or please share me a valid submission which I can upload and test). @veshu, can you help with this?

@Oanh-and-only-Oanh Oanh-and-only-Oanh added the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Jan 14, 2020
@SathyaJayabal SathyaJayabal added the Beta Env Environment label Jan 15, 2020
@veshu
Copy link
Contributor

veshu commented Jan 15, 2020

@nithyaasworld 3. can you please share the challenge link?

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. Beta Env Environment labels Jan 21, 2020
@veshu
Copy link
Contributor

veshu commented Jan 29, 2020

@nithyaasworld This is ready for QA. Could you please verify again.
Thanks!
cc @Oanh-and-only-Oanh

@SathyaJayabal
Copy link
Collaborator

@veshu . Looks good.

Verified in dev

@veshu veshu mentioned this issue Jan 30, 2020
Closed
@veshu
Copy link
Contributor

veshu commented Feb 4, 2020

@SathyaJayabal This is now on prod beta http://beta-community-app.topcoder.com/

Could you please help verify this. Planned deployment for production is tomorrow.
Thanks

@SathyaJayabal SathyaJayabal added Beta Env Environment and removed Dev Env QA Pass labels Feb 4, 2020
@SathyaJayabal SathyaJayabal added the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Feb 4, 2020
@SathyaJayabal
Copy link
Collaborator

@veshu , My submissions count displays as 0 while the the My Submissions and Submissions tab is loading. Once the tab is loaded the count is displayed correctly.

Please see the attached video.
My submisisons.mov.zip

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Feb 4, 2020 via email

@SathyaJayabal
Copy link
Collaborator

Marking as QA pass in Beta. Logging a new issue to track the submissions count issue.

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Feb 4, 2020
@SathyaJayabal SathyaJayabal mentioned this issue Feb 4, 2020
Open
@SathyaJayabal
Copy link
Collaborator

verified on beta (develop branch)
Screenshot 2020-02-06 at 8 17 40 PM

@veshu veshu mentioned this issue Feb 6, 2020
Merged
@SathyaJayabal SathyaJayabal added this to the Community App 0.20.00 milestone Feb 7, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
Screenshot 2020-02-07 at 12 12 39 PM

@veshu , can you please verify this with a valid submission for a MM and let us check if the scores are displayed accordingly.

@lakshmiathreya lakshmiathreya added the QA Pass in PROD Passed verification on Production label Feb 7, 2020
@Oanh-and-only-Oanh Oanh-and-only-Oanh changed the title Submission Management Page Submission Management Page for MM Feb 7, 2020
@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment QA Pass in PROD Passed verification on Production labels Feb 7, 2020
@SathyaJayabal SathyaJayabal added the QA Pass in PROD Passed verification on Production label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veshu veshu

Labels
Challenge Details Screen New feature Prod Env Environment QA Pass in PROD Passed verification on Production QA Pass Submission Management Page
Projects
None yet
Milestone
v0.20.00
Development

No branches or pull requests
7 participants
@veshu @ajefts @nithyaasworld @codeMinter @Oanh-and-only-Oanh @lakshmiathreya @SathyaJayabal