Skip to content

My Challenges served from the members challenge api endpoint #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sushilshinde opened this issue Oct 16, 2019 · 12 comments
Closed

My Challenges served from the members challenge api endpoint #3396

sushilshinde opened this issue Oct 16, 2019 · 12 comments
Assignees

Comments

@sushilshinde
Copy link
Collaborator

https://www.topcoder.com/challenges/30103914

@lakshmiathreya lakshmiathreya added the Need clarification Need clarification to proceed fixing the issue further label Oct 17, 2019
@lakshmiathreya
Copy link

Verified that My Challenges is served from the endpoint as stated in Challenge requirements. Pls clarify reg additional verifications @codeMinter

@codeMinter
Copy link
Contributor

@lakshmiathreya can you please elaborate what clarifications are needed here ?

@codeMinter
Copy link
Contributor

codeMinter commented Oct 18, 2019

If you referring to what else to test, we are targeting to speed up loading of the /challenges page, so not sure if you have tools to test the same. It would be good to get some stats around it so we can then plan to do similar thing for other buckets if this process has speeded up loading of My Challenges bucket?

@sushilshinde anything else you can think of ☝️ ?

@lakshmiathreya
Copy link

@codeMinter we should have noted load times of /challenges page in Dev prior to this change! Now we don't have a reference to compare with. I could note the load times for Prod /challenges page prior to the fix so we have a baseline to compare with after this fix moves to Prod. @Oanh-and-only-Oanh @nithyaasworld your thoughts?

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Oct 18, 2019 via email

@codeMinter
Copy link
Contributor

@sushilshinde can we deploy this to beta so @lakshmiathreya can run a comparison with PROD as they both are served using same backend ?

@codeMinter
Copy link
Contributor

@lakshmiathreya can you please elaborate what clarifications are needed here ?

@lakshmiathreya can you elaborate what clarifications are needed here ?

@lakshmiathreya
Copy link

@codeMinter Clarification requested was regarding specifics of verification - its clear now that /challenges load times need to be noted. thanks! Deploying on beta would help to make a direct comparison as you suggested.

@codeMinter codeMinter removed the Need clarification Need clarification to proceed fixing the issue further label Oct 22, 2019
@sushilshinde
Copy link
Collaborator Author

Currently, these changes are on avail on beta but deployed on dev

@nithyaasworld
Copy link
Collaborator

@codeMinter On dev, the fix seems to be good, apart from the below issue.

Could you check, please?

Steps to reproduce:

  1. Login as dan_developer
  2. Click on View More Challenges present under 'My challenges' section
  3. Scroll to the end of the screen and notice that all the 49 challenges are displayed
  4. Scroll up and disable all the Dev, DS and Design toggle filter
  5. Enable only Design filter and scroll and check
  6. Then Enable Dev too and scroll
  7. Check that it keeps on showing the loading animation

Video:
My Challenges issue02.zip

@codeMinter
Copy link
Contributor

This is on hold so moving back to To Do - the code changes are in place, needs to be deployed and tested once server becomes available

@codeMinter codeMinter removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Dec 4, 2019
@SathyaJayabal
Copy link
Collaborator

we are now using the v5 challenge api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants