-
Notifications
You must be signed in to change notification settings - Fork 212
My Challenges served from the members challenge api endpoint #3396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Verified that My Challenges is served from the endpoint as stated in Challenge requirements. Pls clarify reg additional verifications @codeMinter |
@lakshmiathreya can you please elaborate what clarifications are needed here ? |
If you referring to what else to test, we are targeting to speed up loading of the @sushilshinde anything else you can think of ☝️ ? |
@codeMinter we should have noted load times of /challenges page in Dev prior to this change! Now we don't have a reference to compare with. I could note the load times for Prod /challenges page prior to the fix so we have a baseline to compare with after this fix moves to Prod. @Oanh-and-only-Oanh @nithyaasworld your thoughts? |
Yes, agreed. Please note the time in Prod now for comparison. Thank you
…Sent from my iPhone
On Oct 18, 2019, at 12:55 AM, lakshmiathreya ***@***.***> wrote:
@codeMinter we should have noted load times of /challenges page in Dev prior to this change! Now we don't have a reference to compare with. I could note the load times for Prod /challenges page prior to the fix so we have a baseline to compare with after this fix moves to Prod. @Oanh-and-only-Oanh @nithyaasworld your thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@sushilshinde can we deploy this to |
@lakshmiathreya can you elaborate what clarifications are needed here ? |
@codeMinter Clarification requested was regarding specifics of verification - its clear now that /challenges load times need to be noted. thanks! Deploying on beta would help to make a direct comparison as you suggested. |
Currently, these changes are on avail on beta but deployed on dev |
@codeMinter On dev, the fix seems to be good, apart from the below issue. Could you check, please? Steps to reproduce:
Video: |
This is on hold so moving back to To Do - the code changes are in place, needs to be deployed and tested once server becomes available |
we are now using the v5 challenge api. |
https://www.topcoder.com/challenges/30103914
The text was updated successfully, but these errors were encountered: