-
Notifications
You must be signed in to change notification settings - Fork 212
[$40] Fix the display of the reliability % on profiles #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would like to add that, as per this article, the current reliability rule is: "Member profiles reflect reliability factors for the last 15 projects in each track. The reliability factor is calculated as the percentage of the last 15 projects that a member registers for in which that same member presents a timely submission that passes review. " |
@Oanh-and-only-Oanh Please confirm if we can go by the above rule. Thanks. |
@nithyaasworld , that's correct. Reliability rule is the last 15 projects that a member registers for in each track. @dushyantb @atif FYI |
@dushyantb as discussed with @urwithat, assigning this to you for taking it ahead. Do let me know if anything needed from myside. |
@topcoder-platform/topcodercompetitors this one is now open for pickup. |
Contest https://www.topcoder.com/challenges/30112838 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30112838 has been updated - it has been assigned to PkDurlabhji. |
@PrakashDurlabhji thanks for pickup. Please, PR to https://github.com/topcoder-platform/community-app/tree/feature-member-profiles branch. Thanks |
@kkartunov it means submissionRate is Reliability correct? because on going through the stats object, I see "numInquiries" gives me total challenges and "submissions" no.of submission so far, hence which gives me reliability. raising PR as it is done |
@kkartunov this issue is observed in many other branches such feature-mm-submissions which has no relation with my changes |
@gets0ul is it possible to help a bit? to make understand |
Contest https://www.topcoder.com/challenges/30112838 has been updated - it has been assigned to PkDurlabhji. |
@PrakashDurlabhji the issue #3586 is not seen after removing your commit. We have currently deployed the master without it and it all works well. Step back or I will need to ban you from the repository! |
@kkartunov apology for it , but I still feel my solution is the only solution for this ticket. I wont assign it to myself now sorry again |
Contest https://www.topcoder.com/challenges/30112838 has been updated - it has been assigned to lieutenantroger. |
I would like to take a try. |
@PrakashDurlabhji you feel wrong. We spent enough time on this. As you see here https://github.com/topcoder-platform/community-app/commits/master your commit it reverted and the issue is not there in beta/dev/prod. Check your branch and you will see it there. You can work on it and fix it if you wish to improve. BUT step back here and leave space for others. Thanks |
@LieutenantRoger sure, please. We need a solution that works and won't have consequences like #3586 Good luck! |
Thanks @kkartunov By investing into the issue: do you know the codebase for the members api ? Specifically which code base does this api belong to ? |
And I believe the fix requires changing the backend as well. V3, seems it should be the api codebase with Java version. |
@LieutenantRoger we have confirmation that API updates needed for this one here. Therefore I am putting it |
Putting here Tony's info for reference: I think it’s related to this code: https://github.com/topcoder-platform/tc-website/blob/dev/src/main/com/topcoder/utilities/dwload/TCLoadTCS.java#L753 |
@kkartunov @crazyk07 any prize amount for my efforts which I could get as PR was merged and fix was accepted? as my PR was only solution for it. thanks |
@PrakashDurlabhji your PR was merged but then it was reverted because it was the origin of #3586 as reported from our QA team. I explained this many times to you above. There will be NO prize award for your PR. |
Describe the bug
For example, https://www.topcoder.com/members/birdofpreyru/details/?track=DEVELOP&subTrack=CODE
it’s zero there, but there should be a value
it should have a value like it does here: https://www.topcoder.com/members/FireIce/details/?track=DEVELOP&subTrack=ASSEMBLY_COMPETITION
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Reliability % should have a value like it does here: https://www.topcoder.com/members/FireIce/details/?track=DEVELOP&subTrack=ASSEMBLY_COMPETITION
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
We should have it on all challenge types
Reliability formula is the % of times I submit vs. the times I register
The text was updated successfully, but these errors were encountered: