Skip to content

[$40] Fix the display of the reliability % on profiles #3394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oanh-and-only-Oanh opened this issue Oct 15, 2019 · 46 comments
Open

[$40] Fix the display of the reliability % on profiles #3394

Oanh-and-only-Oanh opened this issue Oct 15, 2019 · 46 comments
Assignees
Labels
Member Profiles On hold P1 Urgent (resolve within 24 hours) tcx_Assigned

Comments

@Oanh-and-only-Oanh
Copy link

Describe the bug

For example, https://www.topcoder.com/members/birdofpreyru/details/?track=DEVELOP&subTrack=CODE

it’s zero there, but there should be a value
it should have a value like it does here: https://www.topcoder.com/members/FireIce/details/?track=DEVELOP&subTrack=ASSEMBLY_COMPETITION

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.topcoder.com/members/birdofpreyru/details/?track=DEVELOP&subTrack=CODE
  2. See the reliability % is zero when there should be a value. Reliability formula is the % of times I submit vs. the times I register

Expected behavior
Reliability % should have a value like it does here: https://www.topcoder.com/members/FireIce/details/?track=DEVELOP&subTrack=ASSEMBLY_COMPETITION

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
We should have it on all challenge types

Reliability formula is the % of times I submit vs. the times I register

@nithyaasworld
Copy link
Collaborator

I would like to add that, as per this article, the current reliability rule is:

"Member profiles reflect reliability factors for the last 15 projects in each track. The reliability factor is calculated as the percentage of the last 15 projects that a member registers for in which that same member presents a timely submission that passes review. "

@nithyaasworld
Copy link
Collaborator

@Oanh-and-only-Oanh Please confirm if we can go by the above rule. Thanks.

@Oanh-and-only-Oanh
Copy link
Author

@nithyaasworld , that's correct. Reliability rule is the last 15 projects that a member registers for in each track. @dushyantb @atif FYI

@codeMinter
Copy link
Contributor

@dushyantb as discussed with @urwithat, assigning this to you for taking it ahead. Do let me know if anything needed from myside.

@kkartunov kkartunov added P1 Urgent (resolve within 24 hours) Member Profiles and removed Member Profiles P2 Important (resolve within 3 days) labels Jan 15, 2020
@kkartunov kkartunov changed the title Fix the display of the reliability % on profiles [$40] Fix the display of the reliability % on profiles Jan 15, 2020
@kkartunov
Copy link
Collaborator

@topcoder-platform/topcodercompetitors this one is now open for pickup.

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112838 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112838 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

@kkartunov
Copy link
Collaborator

@PrakashDurlabhji
Copy link
Contributor

@kkartunov it means submissionRate is Reliability correct? because on going through the stats object, I see "numInquiries" gives me total challenges and "submissions" no.of submission so far, hence which gives me reliability.

raising PR as it is done

@PrakashDurlabhji
Copy link
Contributor

@kkartunov this issue is observed in many other branches such feature-mm-submissions which has no relation with my changes

@PrakashDurlabhji
Copy link
Contributor

@gets0ul is it possible to help a bit? to make understand

@PrakashDurlabhji PrakashDurlabhji self-assigned this Jan 23, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112838 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

@kkartunov
Copy link
Collaborator

@PrakashDurlabhji the issue #3586 is not seen after removing your commit. We have currently deployed the master without it and it all works well.

Step back or I will need to ban you from the repository!

@PrakashDurlabhji
Copy link
Contributor

@kkartunov apology for it , but I still feel my solution is the only solution for this ticket. I wont assign it to myself now sorry again

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30112838 has been updated - it has been assigned to lieutenantroger.

This is an automated message for crazyk via Topcoder X

@LieutenantRoger
Copy link
Collaborator

I would like to take a try.

@kkartunov
Copy link
Collaborator

@PrakashDurlabhji you feel wrong. We spent enough time on this. As you see here https://github.com/topcoder-platform/community-app/commits/master your commit it reverted and the issue is not there in beta/dev/prod. Check your branch and you will see it there. You can work on it and fix it if you wish to improve. BUT step back here and leave space for others.

Thanks

@kkartunov
Copy link
Collaborator

@LieutenantRoger sure, please. We need a solution that works and won't have consequences like #3586

Good luck!

@LieutenantRoger
Copy link
Collaborator

Thanks @kkartunov

By investing into the issue: do you know the codebase for the members api ? Specifically which code base does this api belong to ?

https://api.topcoder.com/v3/members/birdofpreyru/stats

@LieutenantRoger
Copy link
Collaborator

LieutenantRoger commented Jan 23, 2020

And I believe the fix requires changing the backend as well. V3, seems it should be the api codebase with Java version.

@kkartunov
Copy link
Collaborator

@LieutenantRoger we have confirmation that API updates needed for this one here. Therefore I am putting it On hold label. Thanks for your cooperation so far.

@kkartunov
Copy link
Collaborator

Putting here Tony's info for reference:
"those calcs are part of the data loader. I think it actually roots back to the loader that transforms data from the informix oltp to the DW. There is an array of challenge types that it uses to do things like calculate ratings, reliability, etc. I’m pretty sure the appropriate missing challenge types will need to be added and then the loaders will calculate."

I think it’s related to this code: https://github.com/topcoder-platform/tc-website/blob/dev/src/main/com/topcoder/utilities/dwload/TCLoadTCS.java#L753

@PrakashDurlabhji
Copy link
Contributor

@kkartunov @crazyk07 any prize amount for my efforts which I could get as PR was merged and fix was accepted? as my PR was only solution for it. thanks

@kkartunov
Copy link
Collaborator

@PrakashDurlabhji your PR was merged but then it was reverted because it was the origin of #3586 as reported from our QA team. I explained this many times to you above. There will be NO prize award for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Member Profiles On hold P1 Urgent (resolve within 24 hours) tcx_Assigned
Projects
None yet
Development

No branches or pull requests