Skip to content

[$20]Adjust Headings on Challenge Details Page #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Aug 21, 2019 · 22 comments
Closed

[$20]Adjust Headings on Challenge Details Page #3248

veshu opened this issue Aug 21, 2019 · 22 comments
Assignees

Comments

@veshu
Copy link
Contributor

veshu commented Aug 21, 2019

Describe the bug

Adjust Headings on Challenge Details Page

To Reproduce
"1. Go to the Sample challenge page: https://www.topcoder.com/challenges/30095347
2. Check Heading Structure"

Expected behavior
(revised)
H1: Challenge Title
H2: "Key Information" instead of Prizes
H2: All Headings in ""Detail"" Tab"

Actual behavior
(revised)
Prize as Heading 2. It should not be H2

Additional context

Type: Headings

Page: https://www.topcoder.com/challenges/30098244

@veshu veshu added P1 Urgent (resolve within 24 hours) Accessibility labels Aug 21, 2019
@veshu veshu changed the title Adjust Headings on Challenge Details Page [$20]Adjust Headings on Challenge Details Page Aug 21, 2019
@crazyk07
Copy link

[500]: Challenge for the updated issue 3248 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

3 similar comments
@crazyk07
Copy link

[500]: Challenge for the updated issue 3248 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

[500]: Challenge for the updated issue 3248 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

[500]: Challenge for the updated issue 3248 is creating, rescheduling this event

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099941 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099941 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099941 has been updated - it has been assigned to rashmi73.

This is an automated message for crazyk via Topcoder X

@rashmi73
Copy link
Contributor

@veshu
1.can you please clarify on ""H1: ""Challenge Details" i do not find it on page.

@veshu
Copy link
Contributor Author

veshu commented Aug 21, 2019

@crazyk07 @Oanh-and-only-Oanh Can you please help on this?

@rashmi73
Copy link
Contributor

@veshu also it would be helpful If I get some inputs on this too " H3: All Headings in ""Detail"" Tab""

@veshu
Copy link
Contributor Author

veshu commented Aug 21, 2019

@rashmi73 This must mean heading inside details tab https://take.ms/5MAgN

@crazyk07
Copy link

@rashmi73 @veshu sorry, correction and clarification from Original guidance:

H1: The Name of the challenge. This should be H1 on all of our challenge pages. (Pre-existing)
H2: Veshu is correct with his explanation, except the headings in the details portion are all H2 Headings (Pre-existing)

We need to rename the "Prize" Title to "Key Information"
image

And be sure it remains a H2 Heading

@rashmi73
Copy link
Contributor

@veshu I am completely confused after @crazyk07 commented above.
I feel contradictions in expections still I have raised PR to my best given the requirement of issue stated.

PR #3258

@crazyk07
Copy link

Sorry about that. Which point should I clarify?

@rashmi73
Copy link
Contributor

H1: The Name of the challenge. This should be H1 on all of our challenge pages. (Pre-existing)

it is already h1 on challenge page, but issue description says convert it to h2.
so I need to convert it correct?

@crazyk07
Copy link

Ignore the issue description, it is incorrect. I edited it originally.

You do not need to change it if it is already there on the page.

@crazyk07
Copy link

In summary, you only need to change "Prize" to "Key Information" and ensure it remains a H2 Tag. More simplified than before

@rashmi73
Copy link
Contributor

@crazyk07 PR updated according to above comment.
@veshu #3258

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30099941 has been updated - the new changes has been updated for this ticket.

This is an automated message for crazyk via Topcoder X

@lakshmiathreya
Copy link

Verified with Chrome on Win10 and MacOS :-
--'Prize' is changed to 'Key Information' and is h2.
-- Under Details - Heading is h2.
-- Challenge title is h1.

@crazyk07
Copy link

crazyk07 commented Sep 2, 2019

This ticket was not processed for payment. If you would like to process it for payment, please reopen it, add the tcx_FixAccepted label, and then close it again

This is an automated message for crazyk via Topcoder X

@lakshmiathreya lakshmiathreya added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed Ready for Prod QA labels Sep 2, 2019
@lakshmiathreya lakshmiathreya reopened this Sep 2, 2019
@crazyk07 crazyk07 added tcx_Paid and removed Accessibility Challenge Page P1 Urgent (resolve within 24 hours) QA Pass in PROD Passed verification on Production labels Sep 2, 2019
@crazyk07
Copy link

crazyk07 commented Sep 2, 2019

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30099941

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants