Skip to content

General theme fixes #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkartunov opened this issue Aug 5, 2019 · 1 comment
Closed

General theme fixes #3195

kkartunov opened this issue Aug 5, 2019 · 1 comment
Assignees
@kkartunov
Labels
Contentful-DEV Internal development operations for Contentful P4 Low (resolve within 2 weeks)

Comments

@kkartunov
Copy link
Collaborator

The General theme implementation overwrites the Primary and Secondary buttons. It happens here https://github.com/topcoder-platform/community-app/blob/develop/src/shared/components/Contentful/ContentBlock/themes/general.scss#L88-L95

Expected fix:
Buttons should not be influenced by the theme and theme should remain functional.
@kkartunov kkartunov added the Contentful-DEV Internal development operations for Contentful label Aug 5, 2019
@kkartunov kkartunov self-assigned this Aug 5, 2019
@kkartunov kkartunov added the P4 Low (resolve within 2 weeks) label Aug 5, 2019
@kkartunov
Copy link
Collaborator Author

Can be partially fixed. Work is needed in rect-utils-lib...

@kkartunov kkartunov mentioned this issue Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkartunov kkartunov

Labels
Contentful-DEV Internal development operations for Contentful P4 Low (resolve within 2 weeks)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkartunov