Skip to content

[$40]Fix color palette for topcoder react ui kit #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jul 25, 2019 · 11 comments
Closed

[$40]Fix color palette for topcoder react ui kit #3113

veshu opened this issue Jul 25, 2019 · 11 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jul 25, 2019

Based on color palette here https://marvelapp.com/c7h2a6h/screen/59648056/handoff

Please fix the variable name and color code to ensure we have correct color.

@veshu veshu changed the title Fix color palette for topcoder react ui kit [$40]Fix color palette for topcoder react ui kit Jul 25, 2019
@r0hit-gupta
Copy link
Collaborator

@veshu do I change all the variables?

@veshu
Copy link
Contributor Author

veshu commented Jul 25, 2019

@r0hit-gupta yes please make this uniform in ui kit so we don't have to update that lib many times.

Please fix this first before fixing other PR on that repo.

@r0hit-gupta
Copy link
Collaborator

@veshu working on it.

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097677 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097677 has been updated - it has been assigned to rohitgupta_.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097677 has been updated - the new changes has been updated for this ticket.

This is an automated message for lazybaer via Topcoder X

@r0hit-gupta
Copy link
Collaborator

@veshu please review.

@tosha5252
Copy link

tosha5252 commented Jul 29, 2019

@sushilshinde Where do we go to verify this changed? @lakshmiathreya

@veshu
Copy link
Contributor Author

veshu commented Jul 29, 2019

@tosha5252 and @drasticdpk This issue is common for many other issues. And not particular issue, it just updated of brand color. If there is any issue with contrast or color you will have other respective issues. So closing this issue for clarity. Thanks!

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30097677 has been updated - it has been assigned to rohitgupta_.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30097677

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants