-
Notifications
You must be signed in to change notification settings - Fork 212
[$40]Letter, Word and paragraph spacing for paragraphs on all banner and contentBlock themes #3096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This fix will need to cover all themes for banner and contentBlock components. |
Contest https://www.topcoder.com/challenges/30097687 has been created for this ticket. |
Contest https://www.topcoder.com/challenges/30097687 has been updated - the new changes has been updated for this ticket. |
Our regular font size text is 15px so the following should happen:
|
@topcoder-platform/topcodercompetitors this open for pickup. Please, PR against |
@kkartunov the attachment link says access denied. |
@veshu does it require new credentials? |
You can use these ones: |
Contest https://www.topcoder.com/challenges/30097687 has been updated - it has been assigned to rohitgupta_. |
@Dara-K for points 3 & 4, what is the unit of the value? It is |
@r0hit-gupta That's right. Those are pixels too based. |
@r0hit-gupta please let's constraint updates only to |
@Dara-K waiting for your review of the final fix ... |
@lakshmiathreya @r0hit-gupta The unit is good - should be pixels, and it's normal to look like that- weird. |
@Dara-K is everything ok to move this forward? |
based on the font-size of 15px line-height is ok at 25px Windows 10 env |
@sushilshinde Another one to check |
Yes, code is missing on prod |
Verified changed in prod Win10/Chrome |
Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30097687 |
Steps to Reproduce
Expected Result
Actual Result
The letter, Word and paragraph spacing issue
Device: Desktop/Labtop
Browser: Chrome
WCAG Category: 1. Perceivable
WCAG Level: AA
WCAG Success Criterion: 1.4.12 Text Spacing
Screen Reader Used: N/A
Accessibility Audit Tool used: N/A
Attachment
https://topcodermsft-my.sharepoint.com/personal/msft-copilots_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=0bf9d0fe%2Dbdaa%2D4af3%2Dad48%2Dd3fa9f0e20e1&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&sortField=Modified&isAscending=false&id=%2Fpersonal%2Fmsft%2Dcopilots%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2F%5BFAST%5D%20Test%20for%20Accessibility%20Series%2Fcodejam%2F7
The text was updated successfully, but these errors were encountered: