Skip to content

[$80][MSFT-187] Sample challenge page: Keyboard focus does not move to the popup and is not trapped in the challenge prerequisites popup. #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
veshu opened this issue Jul 17, 2019 · 24 comments

Comments

@veshu
Copy link
Contributor

veshu commented Jul 17, 2019

Steps to Reproduce

  1. Go to the sample challenge page: https://www.topcoder.com/challenges/30095347.
  2. Activate the 'register' button'.
  3. There is a poppup which appears with details about the challenge prerequisites.
  4. Note that keyboard focus doesn't move to the poppup and is not trapped inside this poppup, instead we are able to access the elements in the main page.

Expected Result
Keyboard focus should move to the poppup and should not be able to access the elements in the main page till the poppup is dismissed.

Actual Result
Keyboard focus doesn't move to the poppup and is not trapped inside the poppup.

Device: Desktop/Labtop
Operating System: Windows
Browser: Chrome

WCAG Category: 2. Operable
WCAG Level: A
WCAG Success Criterion: 2.1.1 Keyboard
Screen Reader Used: JAWS
Accessibility Audit Tool used: N/A

Attachment
https://topcodermsft-my.sharepoint.com/personal/pd-topcoder_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=088f5f5d%2D9b1c%2D4b7e%2Dacbf%2D320c257c9a9a&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&id=%2Fpersonal%2Fpd%2Dtopcoder%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2FMSFT%2DTeams%2DQA%2FJune%202019%2F29%20Jun%2FTest%20Results%2FBug%20Videos%20%26%20Log%20Files%2FKameshwarid%2Fbug%2033

@veshu veshu changed the title [MSFT-187] Sample challenge page: Keyboard focus does not move to the popup and is not trapped in the challenge prerequisites popup. [$40][MSFT-187] Sample challenge page: Keyboard focus does not move to the popup and is not trapped in the challenge prerequisites popup. Jul 18, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30095988 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30095988 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@veshu veshu changed the title [$40][MSFT-187] Sample challenge page: Keyboard focus does not move to the popup and is not trapped in the challenge prerequisites popup. [$80][MSFT-187] Sample challenge page: Keyboard focus does not move to the popup and is not trapped in the challenge prerequisites popup. Jul 23, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 23, 2019

Contest https://www.topcoder.com/challenges/30095988 has been updated - the new changes has been updated for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 23, 2019

Contest https://www.topcoder.com/challenges/30095988 has been updated - it has been assigned to sadathanwar17.

This is an automated message for lazybaer via Topcoder X

@asadath1395
Copy link

@veshu Can you open this test challenge https://www.topcoder.com/challenges/30095347 or provide me other challenge id where i can reproduce this?
Thanks

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 24, 2019

Contest https://www.topcoder.com/challenges/30096891 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30096891 has been updated - it has been assigned to sadathanwar17.

This is an automated message for lazybaer via Topcoder X

@asadath1395 asadath1395 removed their assignment Jul 25, 2019
@romitgit romitgit self-assigned this Jul 25, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30096891 has been updated - it has been assigned to Timor.

This is an automated message for lazybaer via Topcoder X

@romitgit
Copy link

How to activate the register button ?

@veshu
Copy link
Contributor Author

veshu commented Aug 16, 2019

@r0hit-gupta https://take.ms/MRQaP When tab is opening I can still navigate in header section of main page with tab, see above attached video.

@r0hit-gupta
Copy link
Collaborator

@veshu I have fixed the issue. Please review.

@drasticdpk
Copy link
Collaborator

@veshu @r0hit-gupta I am unable to test it. Please provide test url with credential .

@r0hit-gupta
Copy link
Collaborator

@drasticdpk to test this, First I created a new test account on accounts.topcoder.com and then ran the app in production mode. After that, I tried registering for a challenge and saw the terms popup.

@drasticdpk
Copy link
Collaborator

drasticdpk commented Aug 20, 2019

Thank you @r0hit-gupta . @veshu does code has moved in prod env? Since we are unable to test this issue on dev env.

@veshu
Copy link
Contributor Author

veshu commented Aug 21, 2019

@sushilshinde ☝️

@tosha5252
Copy link

@veshu is there usually a pop-up after registering? I can't reproduce this in prod.

@r0hit-gupta
Copy link
Collaborator

r0hit-gupta commented Aug 23, 2019

@tosha5252 you need to have a brand new account on prod to be able to test this. Try this account testdoe/Topcoder@123

@drasticdpk
Copy link
Collaborator

@tosha5252 @r0hit-gupta , it was verified and working as expected.

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30096891

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests