Skip to content

[$15][MSFT-16] [Challenge Feed] Element is in tab order and does not have accessible text #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
veshu opened this issue Jul 17, 2019 · 16 comments
Closed

[$15][MSFT-16] [Challenge Feed] Element is in tab order and does not have accessible text #2740

veshu opened this issue Jul 17, 2019 · 16 comments
Assignees
@r0hit-gupta
Labels
Accessibility tcx_FixAccepted tcx_Paid

Comments

@veshu
Copy link
Contributor

veshu commented Jul 17, 2019

Steps to Reproduce

  1. Go to https://www.topcoder.com/challenges and Login using valid credentials
  2. Right-click > Inspect Elements
  3. Check the Logo code

Expected Result

  • Element does not have text that is visible to screen readers
  • aria-label attribute does not exist or is empty
  • aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  • Element's default semantics were not overridden with role="presentation"
  • Element's default semantics were not overridden with role="none"

Actual Result
Ensures links have discernible text

Device: Desktop/Labtop
Operating System: Windows
Browser: Chrome

WCAG Category: 2. Operable
WCAG Level: A
WCAG Success Criterion: 2.4.4 Link Purpose (In Context)
Screen Reader Used: N/A
Accessibility Audit Tool used: N/A

Attachment
https://topcodermsft-my.sharepoint.com/personal/pd-topcoder_topcodermsft_onmicrosoft_com/Documents/Forms/All.aspx?cid=58da9b68%2Df2a3%2D45d2%2Dbbae%2D15abdfd0865b&FolderCTID=0x0120005C598A51049FC14CBA882E1AEE168F51&id=%2Fpersonal%2Fpd%2Dtopcoder%5Ftopcodermsft%5Fonmicrosoft%5Fcom%2FDocuments%2FMSFT%2DTeams%2DQA%2FJune%202019%2F29%20Jun%2FTest%20Results%2FBug%20Videos%20%26%20Log%20Files%2Fcodejam%2DAccessibility%2F2
@veshu veshu changed the title [MSFT-16] [Challenge Feed] Element is in tab order and does not have accessible text [$15][MSFT-16] [Challenge Feed] Element is in tab order and does not have accessible text Jul 18, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096123 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30096123 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@r0hit-gupta r0hit-gupta self-assigned this Jul 19, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 19, 2019

Contest https://www.topcoder.com/challenges/30096123 has been updated - it has been assigned to rohitgupta_.

This is an automated message for lazybaer via Topcoder X

@r0hit-gupta r0hit-gupta mentioned this issue Jul 19, 2019
Merged
@sushilshinde
Copy link
Collaborator

Wait for 15 mins

@lakshmiathreya
Copy link

Screenshot 2019-07-22 at 4 23 48 PM

Aria attributes not set ...

@lakshmiathreya lakshmiathreya added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. Ready for QA labels Jul 22, 2019
@codeMinter
Copy link
Contributor

@r0hit-gupta we need to make the change for Mobile Header too. Can you add PR for the mobile header too?

@codeMinter codeMinter mentioned this issue Jul 22, 2019
Closed
@veshu
Copy link
Contributor Author

veshu commented Jul 23, 2019

@r0hit-gupta Please open separate PR for the mobile, so that we don't have revert the changes

@codeMinter codeMinter added tcx_Feedback and removed Merged for QA QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jul 23, 2019
@codeMinter codeMinter mentioned this issue Jul 23, 2019
Closed
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097421 has been created for this ticket.

This is an automated message for lazybaer via Topcoder X

@jmgasper jmgasper assigned r0hit-gupta and unassigned r0hit-gupta Jul 25, 2019
@cwdcwd
Copy link
Contributor

cwdcwd commented Jul 25, 2019

Contest https://www.topcoder.com/challenges/30097421 has been updated - it has been assigned to rohitgupta_.

This is an automated message for lazybaer via Topcoder X

@tosha5252
Copy link

Verified

Env: Windows 10
Browser: Chrome and Edge

@tosha5252
Copy link

Checked using WAVE tool in Chrome Browser...no aria label issues...verified passing

@tosha5252 tosha5252 added QA Pass in PROD Passed verification on Production tcx_FixAccepted and removed Ready for Prod QA labels Jul 30, 2019
@tosha5252
Copy link

OS: Windows 10

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30097421

This is an automated message for crazyk via Topcoder X

@crazyk07 crazyk07 added tcx_Paid and removed Accessibility Challenge Listing QA Pass in PROD Passed verification on Production labels Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r0hit-gupta r0hit-gupta

Labels
Accessibility tcx_FixAccepted tcx_Paid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests