Skip to content

New Nav: Let's collapse second level menu under the following tabs: competitive programming, data science, Statistics #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nithyaasworld opened this issue Jul 2, 2019 · 14 comments
Assignees
Labels
P2 Important (resolve within 3 days) Prod Env Environment QA Pass

Comments

@nithyaasworld
Copy link
Collaborator

let's collapse second level menu under the following tabs: competitive programming, data science, Statistics

@nithyaasworld
Copy link
Collaborator Author

CC: @Oanh-and-only-Oanh

@nithyaasworld
Copy link
Collaborator Author

nithyaasworld commented Jul 10, 2019

Tracks/Statistics Sub-menus are not displayed at the below scenarios:

Steps:

  1. Go to Tracks --> Data Science or Competitive Programming
  2. Click on Tracks and observe that the second level items are not displayed at this point
    image

Same issue exists for Explore --> Statistics too

@nithyaasworld
Copy link
Collaborator Author

nithyaasworld commented Jul 10, 2019

This is also observed by @Oanh-and-only-Oanh

" right now you have to click away from TRACKS and then TRACKS to see the 2nd level menu."

Update: Please make sure this works when user is logged in or logged out.

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld Click in active link was fixed. But I see 2 issues:
1- When click in active link, the subnav blue icon not showing.
2- Not logged user, menu is collapsed by default always.

@nithyaasworld
Copy link
Collaborator Author

@luizrrodrigues No:2 you have stated still exists.

@luizrrodrigues
Copy link
Collaborator

@nithyaasworld We need keep expanded the menu to Not logged user too, right?

@Oanh-and-only-Oanh
Copy link

That's correct, @luizrrodrigues

@SathyaJayabal
Copy link
Collaborator

For not logged in user, the level 1 and level 2 menus disappear.

2705 verification

2705 verification 1

Even when you change the main menu selection, the second level menu is still present
2705 verification 2

@luizrrodrigues
Copy link
Collaborator

The 3rd level menu is a in page menu level, so nav don't affect this. Please check existing page:
https://www.topcoder.com/community/competitive-programming

@luizrrodrigues luizrrodrigues transferred this issue from topcoder-platform/community-app Dec 12, 2019
@luizrrodrigues luizrrodrigues added P2 Important (resolve within 3 days) nav_Feedback labels Dec 12, 2019
@SathyaJayabal
Copy link
Collaborator

Verified.
56 logged out verification 1
56 verification

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal If all good, please add QA Pass tag. Thanks.

@SathyaJayabal
Copy link
Collaborator

SathyaJayabal commented Dec 15, 2019

@luizrrodrigues I dont have access here (topcoder-platform/navigation-component) to edit the labels. @sushilshinde, can you please add me to this repository please ?

@nithyaasworld please add the QA Pass tag, as this has been verified.

@SathyaJayabal
Copy link
Collaborator

Verified

@SathyaJayabal SathyaJayabal reopened this Dec 17, 2019
@SathyaJayabal SathyaJayabal added the Beta Env Environment label Dec 17, 2019
@SathyaJayabal SathyaJayabal added this to the New Navigation Launch milestone Dec 17, 2019
@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Beta Env Environment labels Dec 19, 2019
@SathyaJayabal
Copy link
Collaborator

Verified in production
Screenshot 2019-12-19 at 7 48 09 PM
Uploading Screenshot 2019-12-19 at 7.48.40 PM.png…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Important (resolve within 3 days) Prod Env Environment QA Pass
Projects
None yet
Development

No branches or pull requests

4 participants