Skip to content

$75 | Regarding the nav bar elements, when user is not logged in #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nithyaasworld opened this issue Jun 25, 2019 · 15 comments
Open

$75 | Regarding the nav bar elements, when user is not logged in #2666

nithyaasworld opened this issue Jun 25, 2019 · 15 comments
Labels
nav_OpenForPickup Navigation P3 Normal (resolved within 7 days)

Comments

@nithyaasworld
Copy link
Collaborator

**Environment: **
https://test-community-app.topcoder-dev.com/

Actual behavior
When not logged in, if I navigate to Tracks --> QA, it reloads the whole page. and also nav elements collapsed/expanded state are reset. Happens with most other menus too.

@nithyaasworld nithyaasworld added P3 Normal (resolved within 7 days) Navigation labels Jun 25, 2019
@nithyaasworld
Copy link
Collaborator Author

This is No: 2 stated in this ticket: #2663

@luizrrodrigues luizrrodrigues removed their assignment Jan 9, 2020
@luizrrodrigues luizrrodrigues changed the title Regarding the nav bar elements, when user is not logged in $75 | Regarding the nav bar elements, when user is not logged in Jan 9, 2020
@bappapatra
Copy link

bappapatra commented Jan 10, 2020

I would like to pick it up. unassigned myself from the other issue.

@bappapatra
Copy link

I am working on this issue. need some time,

@bappapatra bappapatra removed their assignment Jan 11, 2020
@bappapatra
Copy link

Its open for pickup.

@LieutenantRoger
Copy link
Collaborator

@luizrrodrigues are you able to reproduce this issue ? I seemed not able to

@LieutenantRoger
Copy link
Collaborator

Up @luizrrodrigues

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Yes, I can reproduce this.

Animation of navigation is reloaded when navigate between pages.

Screen Recording 2020-01-13 at 17.09.57.mov.zip

@LieutenantRoger
Copy link
Collaborator

ok, so the actual issue is when we navigate the level3 menu, the arrow icon in the level2 should be animated from where it left ?

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger We need to remove the animation, this animation is just when expand the Community top level (currently this was expanded by default)

Make sense?

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Please let me know if you working in this one, or if we can open to pickup

@LieutenantRoger
Copy link
Collaborator

Oh, just see this, I will make a PR now and let you check if it's expected.

@LieutenantRoger
Copy link
Collaborator

Here it is: topcoder-platform/navigation-component#109

@luizrrodrigues
Copy link
Collaborator

@LieutenantRoger Looks like just remove the animation, but menu still flashing when navigate between menus.

Note: Term "Remove Animation" is basically to explain, the issue here is about menu refreshing (showing animation when moving between menu)

When expand or in first load (refresh the page - F5) and access page via directly link, still need show the animation.

Screen Recording 2020-01-17 at 20.33.38.mov.zip

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jan 20, 2020

@LieutenantRoger Please let me know the progress of this one or if we can open for pickup.

Thanks.

@LieutenantRoger
Copy link
Collaborator

ok, let's open it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nav_OpenForPickup Navigation P3 Normal (resolved within 7 days)
Projects
None yet
Development

No branches or pull requests

5 participants