Skip to content

topcoder-react-util code clean-up impact #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sushilshinde opened this issue Dec 17, 2018 · 3 comments
Closed

topcoder-react-util code clean-up impact #1830

sushilshinde opened this issue Dec 17, 2018 · 3 comments
Assignees
@ThomasKranitsas

Comments

@sushilshinde
Copy link
Collaborator

sushilshinde commented Dec 17, 2018 •
edited
Loading

Need changes in community app because of the

topcoder-platform/topcoder-react-lib#32

If we decide to do factory function for API then this places might be affected

  1. https://github.com/topcoder-platform/community-app/blob/hot-fixes/src/shared/services/memberCert.js#L8
  2. https://github.com/topcoder-platform/community-app/blob/hot-fixes/src/shared/services/memberCert.js#L16
  3. https://github.com/topcoder-platform/community-app/blob/hot-fixes/src/shared/components/tc-communities/communities/srmx/Home/index.jsx#L18
  4. https://github.com/topcoder-platform/community-app/blob/hot-fixes/src/shared/components/tc-communities/communities/srmx/Home/index.jsx#L37
@ThomasKranitsas ThomasKranitsas changed the title topcoder-react-util code clean-up impact [$10] topcoder-react-util code clean-up impact Feb 7, 2019
@ThomasKranitsas ThomasKranitsas changed the title [$10] topcoder-react-util code clean-up impact topcoder-react-util code clean-up impact Feb 7, 2019
@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30083059 has been created for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30083059 has been updated - the new changes has been updated for this ticket.

This is an automated message for thomaskranitsas via Topcoder X

@ThomasKranitsas
Copy link
Contributor

Paid manually to avoid issues with TCX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasKranitsas ThomasKranitsas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sushilshinde @ThomasKranitsas