Skip to content

Commit fe4ef14

Browse files
committed
Update of TopGear FAQ
Now answers are sticky on desktop (stay within viewport when the page is scrolled down), and the mobile rendering is corrected.
1 parent bde1108 commit fe4ef14

File tree

9 files changed

+44
-5
lines changed

9 files changed

+44
-5
lines changed

__tests__/shared/components/tc-communities/AccordionItem.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe('Click on title', () => {
5353
test('onTitleClick', () => {
5454
const btn = TU.findAllInRenderedTree(page, item =>
5555
item && item.className && item.className.match(/accordion-title-button/));
56-
expect(btn.length).toBe(1);
56+
expect(btn.length).toBe(2);
5757
TU.Simulate.click(btn[0]);
5858
expect(mockOnTitleClick).toHaveBeenCalled();
5959
});

__tests__/shared/components/tc-communities/__snapshots__/Accordion.jsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ exports[`Snapshot match 1`] = `
77
Object {
88
"container": "src-shared-components-tc-communities-Accordion-Accordion-___style__container___2y_cC",
99
"content": "src-shared-components-tc-communities-Accordion-Accordion-___style__content___39ka7",
10+
"title": "src-shared-components-tc-communities-Accordion-Accordion-___style__title___2jqCR",
1011
"titleList": "src-shared-components-tc-communities-Accordion-Accordion-___style__titleList___1AJq5",
1112
"titleListItem": "src-shared-components-tc-communities-Accordion-Accordion-___style__titleListItem___3MrXc",
1213
"titleListItemSelected": "src-shared-components-tc-communities-Accordion-Accordion-___style__titleListItemSelected___2EAYn",

__tests__/shared/components/tc-communities/__snapshots__/AccordionItem.jsx.snap

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ exports[`Snapshot match 1`] = `
88
Object {
99
"containerOpen": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__containerOpen___2_Z8e",
1010
"content": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__content___1dpq2",
11+
"desktop": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__desktop___23r4A",
12+
"mobile": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__mobile___3e9mH",
1113
"title": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__title___1l-ih",
1214
"titleArrow": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__titleArrow___33JDq",
1315
"titleText": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__titleText___1TU4v",
@@ -29,6 +31,8 @@ exports[`Snapshot match 2`] = `
2931
Object {
3032
"containerOpen": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__containerOpen___2_Z8e",
3133
"content": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__content___1dpq2",
34+
"desktop": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__desktop___23r4A",
35+
"mobile": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__mobile___3e9mH",
3236
"title": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__title___1l-ih",
3337
"titleArrow": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__titleArrow___33JDq",
3438
"titleText": "src-shared-components-tc-communities-Accordion-AccordionItem-___style__titleText___1TU4v",

src/shared/components/tc-communities/Accordion/Accordion/index.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ class Accordion extends Component {
4646
<div
4747
onClick={() => this.selectItem(index)}
4848
role="button"
49+
styleName="title"
4950
tabIndex={0}
5051
>{child.props.title}</div>
5152
</li>

src/shared/components/tc-communities/Accordion/Accordion/style.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,3 +70,7 @@
7070
width: 100%;
7171
}
7272
}
73+
74+
.title {
75+
padding-right: 12px;
76+
}

src/shared/components/tc-communities/Accordion/AccordionItem/index.jsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,14 @@ import React from 'react';
1212
import PT from 'prop-types';
1313
import { themr } from 'react-css-themr';
1414
import cn from 'classnames';
15+
import Sticky from 'react-stickynode';
1516
import IconTickDown from '../../../../../assets/images/tc-communities/tick_down_big.svg';
1617
import defaultStyle from './style.scss';
1718

1819
function AccordionItem(props) {
1920
const { title, children, onTitleClick, isOpen, theme } = props;
2021

21-
return (
22+
const content = (
2223
<div className={cn(theme.container, { [theme.containerOpen]: isOpen })}>
2324
<h3 className={theme.title}>
2425
<div
@@ -36,6 +37,13 @@ function AccordionItem(props) {
3637
</div>
3738
</div>
3839
);
40+
41+
return (
42+
<div>
43+
<Sticky styleName="desktop">{content}</Sticky>
44+
<div styleName="mobile">{content}</div>
45+
</div>
46+
);
3947
}
4048

4149
AccordionItem.defaultProps = {

src/shared/components/tc-communities/Accordion/AccordionItem/style.scss

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,24 @@
11
@import '~styles/tc-styles';
22

3+
.desktop {
4+
@include xxs-to-xs {
5+
display: none;
6+
}
7+
}
8+
9+
.mobile {
10+
@include sm-to-lg {
11+
display: none;
12+
}
13+
}
14+
315
.title {
416
border-bottom: 1px solid #d1d3d4;
517
display: none;
618
color: #a3a3ae;
719
cursor: pointer;
8-
height: 60px;
9-
font: 600 15px/60px 'Open Sans';
10-
padding: 0 16px;
20+
font: 600 15px 'Open Sans';
21+
padding: 12px 16px;
1122
position: relative;
1223

1324
@include xxs-to-xs {

src/shared/components/tc-communities/communities/wipro/FAQ/index.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,9 @@ export default function Learn() {
7575
<Section
7676
title="Frequently Asked Questions"
7777
theme={{
78+
container: style.faqContainer,
7879
content: style.faqContent,
80+
title: style.faqTitle,
7981
}}
8082
>
8183
<Accordion>

src/shared/components/tc-communities/communities/wipro/FAQ/style.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,14 @@
99
padding-bottom: 60px;
1010
}
1111

12+
.faqContainer {
13+
padding-top: 0;
14+
}
15+
16+
.faqTitle {
17+
padding-top: 0;
18+
}
19+
1220
.highlighted {
1321
background: #ffc;
1422
}

0 commit comments

Comments
 (0)