Skip to content

Commit ecf1043

Browse files
authored
Merge pull request #6582 from yoution/issue-6581
fix: issue #6581
2 parents 8be8856 + b40e323 commit ecf1043

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

src/shared/components/challenge-listing/Filters/FiltersPanel/index.jsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,12 @@ export default function FiltersPanel({
285285
setTcoToggle(on);
286286
};
287287

288+
useEffect(() => {
289+
if (activeBucket === BUCKETS.MY && tcoToggle) {
290+
onSwitchTcoChallenge(false);
291+
}
292+
}, [activeBucket, tcoToggle]);
293+
288294
const onSwitchRecommendedChallenge = (on) => {
289295
setFilterState({ ..._.clone(filterState), recommended: on });
290296
selectBucket(BUCKETS.OPEN_FOR_REGISTRATION);

src/shared/components/challenge-listing/Listing/Bucket/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ export default function Bucket({
137137
title={BUCKET_DATA[bucket].name}
138138
/>
139139
<h1 styleName="no-results">
140-
{(filterState.recommended && activeBucket === 'openForRegistration') ? null : `${NO_LIVE_CHALLENGES_CONFIG[activeBucket]}`}
140+
{`${NO_LIVE_CHALLENGES_CONFIG[activeBucket]}`}
141141
</h1>
142142
</div>
143143
</div>

src/shared/utils/challenge-listing/buckets.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,8 +217,13 @@ export function isFilterEmpty(filter, tab, bucket) {
217217
let f;
218218
let empty;
219219

220+
if (!filter.tco) {
221+
// eslint-disable-next-line no-param-reassign
222+
delete filter.tco;
223+
}
224+
220225
if (tab === 'past') {
221-
f = _.pick(filter, 'tracks', 'search', 'types', 'startDateEnd', 'endDateStart');
226+
f = _.pick(filter, 'tracks', 'search', 'types', 'startDateEnd', 'endDateStart', 'tco');
222227
if (f.types) f.types = [...f.types].sort();
223228
empty = {
224229
tracks: {
@@ -245,7 +250,7 @@ export function isFilterEmpty(filter, tab, bucket) {
245250
reviewOpportunityTypes: _.keys(REVIEW_OPPORTUNITY_TYPES),
246251
};
247252
} else {
248-
f = _.pick(filter, 'tracks', 'search', 'types');
253+
f = _.pick(filter, 'tracks', 'search', 'types', 'tco');
249254
if (f.types) f.types = [...f.types].sort();
250255
empty = {
251256
tracks: {

0 commit comments

Comments
 (0)