Skip to content

Commit d67a163

Browse files
Challenge Details - Fix submissions memberHandle
1 parent 03e0bcc commit d67a163

File tree

2 files changed

+8
-8
lines changed
  • src/shared

2 files changed

+8
-8
lines changed

src/shared/components/challenge-detail/Submissions/index.jsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,8 @@ class SubmissionsComponent extends React.Component {
175175
valueA = `${a.member || ''}`.toLowerCase();
176176
valueB = `${b.member || ''}`.toLowerCase();
177177
} else {
178-
valueA = `${a.createdBy}`.toLowerCase();
179-
valueB = `${b.createdBy}`.toLowerCase();
178+
valueA = _.get(a.registrant, 'memberHandle', '');
179+
valueB = _.get(b.registrant, 'memberHandle', '');
180180
}
181181
valueIsString = true;
182182
break;
@@ -314,12 +314,12 @@ class SubmissionsComponent extends React.Component {
314314
{`#${s.id}`}
315315
</a>
316316
<a
317-
href={`${window.origin}/members/${s.createdBy}`}
317+
href={`${window.origin}/members/${_.get(s.registrant, 'memberHandle', '')}`}
318318
target={`${_.includes(window.origin, 'www') ? '_self' : '_blank'}`}
319319
rel="noopener noreferrer"
320320
styleName={`level-${getRatingLevel(_.get(s.registrant, 'rating', 0))}`}
321321
>
322-
{s.createdBy}
322+
{_.get(s.registrant, 'memberHandle', '')}
323323
</a>
324324
</div>
325325
<div>
@@ -705,7 +705,7 @@ class SubmissionsComponent extends React.Component {
705705
{
706706
!isMM && (
707707
sortedSubmissions.map(s => (
708-
<div key={s.createdBy + s.created} styleName="row">
708+
<div key={_.get(s.registrant, 'memberHandle', '') + s.created} styleName="row">
709709
{
710710
!isF2F && !isBugHunt && (
711711
<div styleName={`col-2 level-${getRatingLevel(_.get(s.registrant, 'rating', 0))}`}>
@@ -715,12 +715,12 @@ class SubmissionsComponent extends React.Component {
715715
}
716716
<div styleName="col-3">
717717
<a
718-
href={`${window.origin}/members/${s.createdBy}`}
718+
href={`${window.origin}/members/${_.get(s.registrant, 'memberHandle', '')}`}
719719
target={`${_.includes(window.origin, 'www') ? '_self' : '_blank'}`}
720720
rel="noopener noreferrer"
721721
styleName={`handle level-${getRatingLevel(_.get(s.registrant, 'rating', 0))}`}
722722
>
723-
{s.createdBy}
723+
{_.get(s.registrant, 'memberHandle', '')}
724724
</a>
725725
</div>
726726
<div styleName="col-4">

src/shared/containers/challenge-detail/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ function mapStateToProps(state, props) {
721721
if (challenge.submissions) {
722722
challenge.submissions = challenge.submissions.map(submission => ({
723723
...submission,
724-
registrant: _.find(challenge.registrants, { memberHandle: submission.createdBy }),
724+
registrant: _.find(challenge.registrants, r => (`${r.memberId}` === `${submission.memberId}`)),
725725
}));
726726
}
727727

0 commit comments

Comments
 (0)