Skip to content

Commit d1b40f6

Browse files
Merge branch 'issue-5088-gets0ul' into bug-bash
2 parents fc86b83 + 5017bdb commit d1b40f6

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/shared/components/challenge-listing/Listing/Bucket/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ export default function Bucket({
184184
{placeholders}
185185
{
186186
// (expandable || loadMore) && (expandable || !keepPlaceholders) && !loading && !expanded ? (
187-
(expanding || expandable) && !loading && !expanded && loadMore ? (
187+
(expanding || expandable) && !loading && loadMore && (expandable ? expanded : !expanded) ? (
188188
<a
189189
// href={`${challengesUrl}?${bucketQuery}`}
190190
href={`${challengesUrl}`}

src/shared/components/challenge-listing/Listing/index.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,7 @@ function Listing({
182182
);
183183
};
184184

185-
if (!expanding && (activeBucket !== BUCKETS.ALL)
186-
&& (activeBucket !== BUCKETS.SAVED_FILTER)) {
185+
if ((activeBucket !== BUCKETS.SAVED_FILTER)) {
187186
return (
188187
<div styleName="challengeCardContainer">
189188
{getBucket(activeBucket, true)}
@@ -207,7 +206,8 @@ function Listing({
207206
// }
208207
const loading = loadingMyChallenges
209208
|| loadingOpenForRegistrationChallenges
210-
|| loadingOnGoingChallenges;
209+
|| loadingOnGoingChallenges
210+
|| loadingAllChallenges;
211211
const placeholders = [];
212212
if (challenges.length > 0 || (activeBucket === BUCKETS.ALL && allChallenges.length > 0)) {
213213
return (

0 commit comments

Comments
 (0)