Skip to content

Commit d154da9

Browse files
committed
Put Banner, Nav, Main, Contentinfo Landmark
1 parent 19a4d79 commit d154da9

File tree

10 files changed

+24
-24
lines changed

10 files changed

+24
-24
lines changed

src/shared/components/Dashboard/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default function Dashboard({
4444
}) {
4545
return (
4646
<div styleName="container">
47-
<div styleName="page">
47+
<div styleName="page" role="main">
4848
<Header
4949
achievements={achievements}
5050
achievementsLoading={achievementsLoading}

src/shared/components/ProfilePage/Stats/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class ProfileStats extends React.Component {
8080
}
8181

8282
return (
83-
<div styleName="profile-subtrack-container">
83+
<div styleName="profile-subtrack-container" role="main">
8484
<div styleName="content">
8585
<div styleName="page-state-header">
8686
<header>

src/shared/components/ProfilePage/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class ProfilePage extends React.Component {
167167
/>
168168
)
169169
}
170-
<div styleName="profile-container">
170+
<div styleName="profile-container" role="main">
171171
<div styleName="about-container">
172172
<div styleName="profile-header-container">
173173
<Sticky

src/shared/components/ReviewOpportunityDetailsPage/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const ReviewOpportunityDetailsPage = ({
3838
toggleRole,
3939
}) => (
4040
<div styleName="outer-container">
41-
<div styleName="page">
41+
<div styleName="page" role="main">
4242

4343
<div styleName="header">
4444
<h1 styleName="challenge-title">

src/shared/components/SubmissionPage/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ function SubmissionsPage(props) {
4040

4141
return (
4242
<div styleName="container">
43-
<div styleName="content">
43+
<div styleName="content" role="main">
4444
<Header
4545
challengeId={challengeId}
4646
challengesUrl={challengesUrl}

src/shared/components/TopcoderFooter/index.jsx

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,26 +33,24 @@ export default function TopcoderFooter() {
3333
const base = config.URL.BASE;
3434
const currentYear = moment().year();
3535
return (
36-
<div styleName="footer">
37-
<nav>
38-
<ul>
39-
<Link to={`${base}/community/about`}>
36+
<div styleName="footer" role="contentinfo">
37+
<ul>
38+
<Link to={`${base}/community/about`}>
4039
ABOUT US
41-
</Link>
42-
<Link to={`${base}/community/contact`}>
40+
</Link>
41+
<Link to={`${base}/community/contact`}>
4342
CONTACT US
44-
</Link>
45-
<Link to={config.URL.HELP}>
43+
</Link>
44+
<Link to={config.URL.HELP}>
4645
HELP CENTER
47-
</Link>
48-
<Link to={`${base}/community/how-it-works/privacy-policy/`}>
46+
</Link>
47+
<Link to={`${base}/community/how-it-works/privacy-policy/`}>
4948
PRIVACY POLICY
50-
</Link>
51-
<Link to={`${base}/community/how-it-works/terms/`}>
49+
</Link>
50+
<Link to={`${base}/community/how-it-works/terms/`}>
5251
TERMS
53-
</Link>
54-
</ul>
55-
</nav>
52+
</Link>
53+
</ul>
5654
<div styleName="social-links">
5755
<hr />
5856
<a href="https://www.facebook.com/topcoder" target="fbwindow">

src/shared/components/TopcoderHeader/index.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,7 @@ export default class TopcoderHeader extends React.Component {
337337
return (
338338
<div
339339
styleName="header"
340+
role="banner"
340341
ref={(div) => { this.headerRoot = div; }}
341342
onMouseLeave={() => {
342343
if (openedMenu) {
@@ -351,7 +352,7 @@ export default class TopcoderHeader extends React.Component {
351352
<a href={BASE_URL} styleName="logo" aria-label="Topcoder Homepage">
352353
<LogoTopcoderWithName height={53} width={135} />
353354
</a>
354-
<ul styleName="main-menu" ref={(ul) => { this.mainMenu = ul; }}>
355+
<ul styleName="main-menu" role="navigation" ref={(ul) => { this.mainMenu = ul; }}>
355356
{mainMenu}
356357
</ul>
357358
<div styleName="right-menu">
@@ -401,6 +402,7 @@ export default class TopcoderHeader extends React.Component {
401402
styleName="search-field"
402403
>
403404
<input
405+
role="search"
404406
ref={(input) => { this.searchInput = input; }}
405407
onKeyPress={(event) => {
406408
if (event.key === 'Enter') {

src/shared/containers/SubmissionManagement/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ class SubmissionManagementPageContainer extends React.Component {
8181

8282
return (
8383
<div styleName="outer-container">
84-
<div styleName="submission-management-container">
84+
<div styleName="submission-management-container" role="main">
8585
{!isEmpty
8686
&& (
8787
<SubmissionManagement

src/shared/containers/challenge-detail/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ class ChallengeDetailPageContainer extends React.Component {
284284

285285
return (
286286
<div styleName="outer-container">
287-
<div styleName="challenge-detail-container">
287+
<div styleName="challenge-detail-container" role="main">
288288
{ Boolean(isEmpty) && (
289289
<div styleName="page">
290290
Challenge #

src/shared/containers/challenge-listing/Listing/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ export class ListingContainer extends React.Component {
237237
}
238238

239239
return (
240-
<div styleName="container">
240+
<div styleName="container" role="main">
241241
<MetaTags
242242
description={description}
243243
image={ogImage}

0 commit comments

Comments
 (0)