Skip to content

Commit c63c105

Browse files
authored
Merge pull request #255 from chqy24/issue_208
Fixes #208 Fixes #218 Fixes #228
2 parents f8ff23b + 6a18ac5 commit c63c105

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

src/shared/components/challenge-detail/Submissions/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export default function Submissions(props) {
8484
</div>
8585
<div styleName="col-2">{moment(s.submissionDate).format('MMM DD, YYYY HH:mm')} EDT</div>
8686
<div styleName="col-3">
87-
{s.initialScore.toFixed(2)} / {s.finalScore.toFixed(2)}
87+
{(s.initialScore || 0).toFixed(2)} / {(s.finalScore || 0).toFixed(2)}
8888
</div>
8989
</div>
9090
))

src/shared/components/challenge-detail/Winners/index.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ export default function Winners(props) {
2727
isDesign,
2828
} = props;
2929

30-
results.sort((a, b) => a.placement - b.placement);
30+
const maxPlace = Number.MAX_SAFE_INTEGER;
31+
results.sort((a, b) => (_.isNumber(a.placement) ? a.placement : maxPlace) -
32+
(_.isNumber(b.placement) ? b.placement : maxPlace));
3133
const winners = results.slice(0, prizes.length);
3234

3335
return (

src/shared/containers/challenge-detail/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ ChallengeDetailPageContainer.propTypes = {
287287
function extractChallengeDetail(v3, v2, challengeId) {
288288
let challenge = {};
289289
if (!_.isEmpty(v3)) {
290-
challenge = _.clone(v3);
290+
challenge = _.defaults(_.clone(v3), { prizes: [] });
291291
if (!_.isEmpty(v2)) {
292292
challenge.numberOfCheckpointsPrizes = v2.numberOfCheckpointsPrizes;
293293
challenge.introduction = v2.introduction;

0 commit comments

Comments
 (0)