Merge pull request #4558 from topcoder-platform/issue-4536

Issue#4536 : Hide Submission tab if user not logged

Author: sushilshinde

src/shared/components/challenge-detail/Header/TabSelector/index.jsx

@@ -19,6 +19,7 @@ function getSelectorStyle(selectedView, currentView) {
 
 export default function ChallengeViewSelector(props) {
   const {
+    isLoggedIn,
     challenge,
     checkpointCount,
     numOfRegistrants,
@@ -123,7 +124,7 @@ export default function ChallengeViewSelector(props) {
           )
         }
         {
-          numOfSubmissions ? (
+          (numOfSubmissions && isLoggedIn) ? (
             <a
               tabIndex="0"
               role="tab"
@@ -186,6 +187,7 @@ export default function ChallengeViewSelector(props) {
 }
 
 ChallengeViewSelector.defaultProps = {
+  isLoggedIn: false,
   challenge: {},
   checkpointCount: 0,
   numOfRegistrants: 0,
@@ -194,6 +196,7 @@ ChallengeViewSelector.defaultProps = {
 };
 
 ChallengeViewSelector.propTypes = {
+  isLoggedIn: PT.bool,
   challenge: PT.shape({
     subTrack: PT.any,
     details: PT.shape({

src/shared/components/challenge-detail/Header/index.jsx

@@ -34,6 +34,7 @@ const DAY_MS = 24 * HOUR_MS;
 
 export default function ChallengeHeader(props) {
   const {
+    isLoggedIn,
     challenge,
     challengesUrl,
     challengeTypes,
@@ -447,6 +448,7 @@ export default function ChallengeHeader(props) {
           }
         </div>
         <TabSelector
+          isLoggedIn={isLoggedIn}
           challenge={challenge}
           onSelectorClicked={onSelectorClicked}
           trackLower={trackLower}
@@ -465,6 +467,7 @@ export default function ChallengeHeader(props) {
 }
 
 ChallengeHeader.defaultProps = {
+  isLoggedIn: false,
   checkpoints: {},
   isMenuOpened: false,
   hasThriveArticles: false,
@@ -473,6 +476,7 @@ ChallengeHeader.defaultProps = {
 };
 
 ChallengeHeader.propTypes = {
+  isLoggedIn: PT.bool,
   checkpoints: PT.shape(),
   challenge: PT.shape({
     id: PT.string.isRequired,

src/shared/containers/challenge-detail/index.jsx

@@ -365,6 +365,8 @@ class ChallengeDetailPageContainer extends React.Component {
 
     const submissionsViewable = _.find(metadata, { type: 'submissionsViewable' });
 
+    const isLoggedIn = !_.isEmpty(auth.tokenV3);
+
     /* Generation of data for SEO meta-tags. */
     let prizesStr;
     if (challenge.prizes && challenge.prizes.length) {
@@ -445,6 +447,7 @@ class ChallengeDetailPageContainer extends React.Component {
             !isEmpty
             && (
             <ChallengeHeader
+              isLoggedIn={isLoggedIn}
               challenge={challenge}
               challengeId={challengeId}
               challengeTypes={challengeTypes}
@@ -523,7 +526,7 @@ class ChallengeDetailPageContainer extends React.Component {
             )
           }
           {
-            !isEmpty && selectedTab === DETAIL_TABS.SUBMISSIONS
+            !isEmpty && isLoggedIn && selectedTab === DETAIL_TABS.SUBMISSIONS
             && (
               <Submissions
                 challenge={challenge}