Skip to content

Commit b72b8e5

Browse files
authored
Merge pull request #4725 from cagdas001/integration-v5-challenge-api
fix(challenge-listing): sorting functions
2 parents 7430f7c + 76529d7 commit b72b8e5

File tree

2 files changed

+128
-43
lines changed

2 files changed

+128
-43
lines changed

package-lock.json

+112-36
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/shared/utils/challenge-listing/sort.js

+16-7
Original file line numberDiff line numberDiff line change
@@ -41,26 +41,35 @@ export default {
4141
name: 'Prize high to low',
4242
},
4343
[SORTS.TIME_TO_REGISTER]: {
44-
func: (a, b) => moment(a.registrationEndDate || a.submissionEndDate)
45-
.diff(b.registrationEndDate || b.submissionEndDate),
44+
func: (a, b) => {
45+
const aDate = moment(a.registrationEndDate || a.submissionEndTimestamp);
46+
const bDate = moment(b.registrationEndDate || b.submissionEndTimestamp);
47+
48+
if (aDate.isBefore() && bDate.isAfter()) return 1;
49+
if (aDate.isAfter() && bDate.isBefore()) return -1;
50+
if (aDate.isBefore() && bDate.isBefore()) return bDate.diff(aDate);
51+
52+
return aDate.diff(bDate);
53+
},
4654
name: 'Time to register',
4755
},
4856
[SORTS.TIME_TO_SUBMIT]: {
4957
func: (a, b) => {
5058
function nextSubEndDate(o) {
5159
if (o.checkpointSubmissionEndDate && moment(o.checkpointSubmissionEndDate).isAfter()) {
52-
return o.checkpointSubmissionEndDate;
60+
return moment(o.checkpointSubmissionEndDate);
5361
}
54-
return o.submissionEndDate;
62+
return moment(o.submissionEndTimestamp);
5563
}
5664

5765
const aDate = nextSubEndDate(a);
5866
const bDate = nextSubEndDate(b);
5967

60-
if (moment(aDate).isBefore()) return 1;
61-
if (moment(bDate).isBefore()) return -1;
68+
if (aDate.isBefore() && bDate.isAfter()) return 1;
69+
if (aDate.isAfter() && bDate.isBefore()) return -1;
70+
if (aDate.isBefore() && bDate.isBefore()) return bDate.diff(aDate);
6271

63-
return moment(aDate).diff(bDate);
72+
return aDate.diff(bDate);
6473
},
6574
name: 'Time to submit',
6675
},

0 commit comments

Comments
 (0)