Skip to content

Commit b35a64e

Browse files
committed
Merge pull request #3191 from gets0ul/issue-2817-fix2
Fix the reading of Topcoder Logo
1 parent 0fc7f92 commit b35a64e

File tree

2 files changed

+8
-5
lines changed
  • __tests__/shared/components/TopcoderHeader/__snapshots__
  • src/shared/components/TopcoderHeader

2 files changed

+8
-5
lines changed

__tests__/shared/components/TopcoderHeader/__snapshots__/index.jsx.snap

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,13 @@ exports[`Default render 1`] = `
1010
className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
1111
>
1212
<a
13-
aria-label="Topcoder Homepage"
13+
aria-label="Topcoder Logo link to Topcoder Homepage"
1414
className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
1515
href="https://www.topcoder-dev.com"
1616
>
1717
<LogoTopcoderWithName
1818
height={53}
19+
title="Topcoder Logo link to Topcoder Homepage"
1920
viewBox="0 0 135 21"
2021
width={135}
2122
xmlns="http://www.w3.org/2000/svg"
@@ -296,12 +297,13 @@ exports[`Render with open menu 1`] = `
296297
className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
297298
>
298299
<a
299-
aria-label="Topcoder Homepage"
300+
aria-label="Topcoder Logo link to Topcoder Homepage"
300301
className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
301302
href="https://www.topcoder-dev.com"
302303
>
303304
<LogoTopcoderWithName
304305
height={53}
306+
title="Topcoder Logo link to Topcoder Homepage"
305307
viewBox="0 0 135 21"
306308
width={135}
307309
xmlns="http://www.w3.org/2000/svg"
@@ -593,12 +595,13 @@ exports[`Render with specified profile 1`] = `
593595
className="src-shared-components-TopcoderHeader-___style__main-desktop-header___oqm_l"
594596
>
595597
<a
596-
aria-label="Topcoder Homepage"
598+
aria-label="Topcoder Logo link to Topcoder Homepage"
597599
className="src-shared-components-TopcoderHeader-___style__logo___2WLJ0"
598600
href="https://www.topcoder-dev.com"
599601
>
600602
<LogoTopcoderWithName
601603
height={53}
604+
title="Topcoder Logo link to Topcoder Homepage"
602605
viewBox="0 0 135 21"
603606
width={135}
604607
xmlns="http://www.w3.org/2000/svg"

src/shared/components/TopcoderHeader/index.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,8 @@ export default class TopcoderHeader extends React.Component {
351351
}}
352352
>
353353
<div styleName="main-desktop-header">
354-
<a href={BASE_URL} styleName="logo" aria-label="Topcoder Homepage">
355-
<LogoTopcoderWithName height={53} width={135} />
354+
<a href={BASE_URL} styleName="logo" aria-label="Topcoder Logo link to Topcoder Homepage">
355+
<LogoTopcoderWithName height={53} width={135} title="Topcoder Logo link to Topcoder Homepage" />
356356
</a>
357357
<ul styleName="main-menu" role="navigation" ref={(ul) => { this.mainMenu = ul; }}>
358358
{mainMenu}

0 commit comments

Comments
 (0)