Skip to content

Commit 9b2d8c1

Browse files
Merge branch 'issue_4982' of https://github.com/PrakashDurlabhji/community-app into PrakashDurlabhji-issue_4982
2 parents 3692d7b + 75b1ae5 commit 9b2d8c1

File tree

2 files changed

+50
-56
lines changed

2 files changed

+50
-56
lines changed

src/shared/utils/challenge-listing/buckets.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ export const BUCKET_DATA = {
4242
name: 'My Challenges',
4343
sorts: [
4444
SORTS.MOST_RECENT_START_DATE,
45-
// SORTS.TIME_TO_SUBMIT,
45+
SORTS.TIME_TO_SUBMIT,
4646
// SORTS.NUM_REGISTRANTS,
4747
// SORTS.NUM_SUBMISSIONS,
48-
// SORTS.PRIZE_HIGH_TO_LOW,
48+
SORTS.PRIZE_HIGH_TO_LOW,
4949
SORTS.TITLE_A_TO_Z,
5050
],
5151
},
@@ -59,11 +59,11 @@ export const BUCKET_DATA = {
5959
name: 'Open for registration',
6060
sorts: [
6161
SORTS.MOST_RECENT_START_DATE,
62-
// SORTS.TIME_TO_REGISTER,
63-
// SORTS.TIME_TO_SUBMIT,
62+
SORTS.TIME_TO_REGISTER,
63+
SORTS.TIME_TO_SUBMIT,
6464
// SORTS.NUM_REGISTRANTS,
6565
// SORTS.NUM_SUBMISSIONS,
66-
// SORTS.PRIZE_HIGH_TO_LOW,
66+
SORTS.PRIZE_HIGH_TO_LOW,
6767
SORTS.TITLE_A_TO_Z,
6868
],
6969
},
@@ -78,9 +78,9 @@ export const BUCKET_DATA = {
7878
name: 'Ongoing challenges',
7979
sorts: [
8080
SORTS.MOST_RECENT_START_DATE,
81-
// SORTS.CURRENT_PHASE,
81+
SORTS.CURRENT_PHASE,
8282
SORTS.TITLE_A_TO_Z,
83-
// SORTS.PRIZE_HIGH_TO_LOW,
83+
SORTS.PRIZE_HIGH_TO_LOW,
8484
],
8585
},
8686
[BUCKETS.UPCOMING]: {

src/shared/utils/challenge-listing/sort.js

Lines changed: 43 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -7,79 +7,73 @@ import { sumBy } from 'lodash';
77
// import { phaseStartDate, phaseEndDate } from './helper';
88

99
export const SORTS = {
10-
// CURRENT_PHASE: 'current-phase',
10+
CURRENT_PHASE: 'current-phase',
1111
MOST_RECENT: 'updated',
1212
MOST_RECENT_START_DATE: 'startDate',
1313
// NUM_REGISTRANTS: 'num-registrants',
1414
// NUM_SUBMISSIONS: 'num-submissions',
15-
// PRIZE_HIGH_TO_LOW: 'prize-high-to-low',
16-
// TIME_TO_REGISTER: 'time-to-register',
17-
// TIME_TO_SUBMIT: 'time-to-submit',
15+
PRIZE_HIGH_TO_LOW: 'overview.totalPrizes',
16+
TIME_TO_REGISTER: 'registrationEndDate',
17+
TIME_TO_SUBMIT: 'submissionEndDate',
1818
TITLE_A_TO_Z: 'name',
1919
REVIEW_OPPORTUNITIES_TITLE_A_TO_Z: 'review-opportunities-title-a-to-z',
2020
REVIEW_OPPORTUNITIES_PAYMENT: 'review-opportunities-payment',
2121
REVIEW_OPPORTUNITIES_START_DATE: 'review-opportunities-start-date',
2222
};
2323

2424
export default {
25-
// [SORTS.CURRENT_PHASE]: {
26-
// func: (a, b) => a.status.localeCompare(b.status),
27-
// name: 'Current phase',
28-
// },
25+
[SORTS.CURRENT_PHASE]: {
26+
func: (a, b) => a.status.localeCompare(b.status),
27+
name: 'Current phase',
28+
},
2929
[SORTS.MOST_RECENT]: {
30-
// func: (a, b) => moment(b.registrationStartDate).diff(a.registrationStartDate),
3130
name: 'Most recent',
3231
order: 'desc',
3332
},
3433
[SORTS.MOST_RECENT_START_DATE]: {
3534
name: 'Most recent',
3635
order: 'desc',
3736
},
38-
// [SORTS.NUM_REGISTRANTS]: {
39-
// func: (a, b) => b.numOfRegistrants - a.numOfRegistrants,
40-
// name: '# of registrants',
41-
// },
42-
// [SORTS.NUM_SUBMISSIONS]: {
43-
// func: (a, b) => b.numOfSubmissions - a.numOfSubmissions,
44-
// name: '# of submissions',
45-
// },
46-
// [SORTS.PRIZE_HIGH_TO_LOW]: {
47-
// func: (a, b) => b.totalPrize - a.totalPrize,
48-
// name: 'Prize high to low',
49-
// },
50-
// [SORTS.TIME_TO_REGISTER]: {
51-
// func: (a, b) => {
52-
// const aDate = moment(a.registrationEndDate || a.submissionEndTimestamp);
53-
// const bDate = moment(b.registrationEndDate || b.submissionEndTimestamp);
37+
[SORTS.PRIZE_HIGH_TO_LOW]: {
38+
func: (a, b) => b.totalPrize - a.totalPrize,
39+
name: 'Prize high to low',
40+
order: 'desc',
41+
},
42+
[SORTS.TIME_TO_REGISTER]: {
43+
func: (a, b) => {
44+
const aDate = moment(a.registrationEndDate || a.submissionEndTimestamp);
45+
const bDate = moment(b.registrationEndDate || b.submissionEndTimestamp);
5446

55-
// if (aDate.isBefore() && bDate.isAfter()) return 1;
56-
// if (aDate.isAfter() && bDate.isBefore()) return -1;
57-
// if (aDate.isBefore() && bDate.isBefore()) return bDate.diff(aDate);
47+
if (aDate.isBefore() && bDate.isAfter()) return 1;
48+
if (aDate.isAfter() && bDate.isBefore()) return -1;
49+
if (aDate.isBefore() && bDate.isBefore()) return bDate.diff(aDate);
5850

59-
// return aDate.diff(bDate);
60-
// },
61-
// name: 'Time to register',
62-
// },
63-
// [SORTS.TIME_TO_SUBMIT]: {
64-
// func: (a, b) => {
65-
// function nextSubEndDate(o) {
66-
// if (o.checkpointSubmissionEndDate && moment(o.checkpointSubmissionEndDate).isAfter()) {
67-
// return moment(o.checkpointSubmissionEndDate);
68-
// }
69-
// return moment(o.submissionEndTimestamp);
70-
// }
51+
return aDate.diff(bDate);
52+
},
53+
name: 'Time to register',
54+
order: 'desc',
55+
},
56+
[SORTS.TIME_TO_SUBMIT]: {
57+
func: (a, b) => {
58+
function nextSubEndDate(o) {
59+
if (o.checkpointSubmissionEndDate && moment(o.checkpointSubmissionEndDate).isAfter()) {
60+
return moment(o.checkpointSubmissionEndDate);
61+
}
62+
return moment(o.submissionEndTimestamp);
63+
}
7164

72-
// const aDate = nextSubEndDate(a);
73-
// const bDate = nextSubEndDate(b);
65+
const aDate = nextSubEndDate(a);
66+
const bDate = nextSubEndDate(b);
7467

75-
// if (aDate.isBefore() && bDate.isAfter()) return 1;
76-
// if (aDate.isAfter() && bDate.isBefore()) return -1;
77-
// if (aDate.isBefore() && bDate.isBefore()) return bDate.diff(aDate);
68+
if (aDate.isBefore() && bDate.isAfter()) return 1;
69+
if (aDate.isAfter() && bDate.isBefore()) return -1;
70+
if (aDate.isBefore() && bDate.isBefore()) return bDate.diff(aDate);
7871

79-
// return aDate.diff(bDate);
80-
// },
81-
// name: 'Time to submit',
82-
// },
72+
return aDate.diff(bDate);
73+
},
74+
name: 'Time to submit',
75+
order: 'desc',
76+
},
8377
[SORTS.TITLE_A_TO_Z]: {
8478
// func: (a, b) => a.name.localeCompare(b.name),
8579
name: 'Title A-Z',

0 commit comments

Comments
 (0)